Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sudo: 1.8.25 -> 1.8.25p1 (bugfix for systems w/o ppoll) #46682

Closed
wants to merge 1 commit into from
Closed

sudo: 1.8.25 -> 1.8.25p1 (bugfix for systems w/o ppoll) #46682

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 15, 2018

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sudo

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sudo

Partial log (click to expand)

shrinking /nix/store/0ffykrzff0s2zkhgzp2qbkdibvspcnqr-sudo-1.8.25p1/bin/sudoreplay
shrinking /nix/store/0ffykrzff0s2zkhgzp2qbkdibvspcnqr-sudo-1.8.25p1/bin/sudo
shrinking /nix/store/0ffykrzff0s2zkhgzp2qbkdibvspcnqr-sudo-1.8.25p1/bin/cvtsudoers
gzipping man pages under /nix/store/0ffykrzff0s2zkhgzp2qbkdibvspcnqr-sudo-1.8.25p1/share/man/
strip is /nix/store/2wds0imn9hw7bmana0m1ffb9zm8kcgvd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0ffykrzff0s2zkhgzp2qbkdibvspcnqr-sudo-1.8.25p1/libexec  /nix/store/0ffykrzff0s2zkhgzp2qbkdibvspcnqr-sudo-1.8.25p1/bin  /nix/store/0ffykrzff0s2zkhgzp2qbkdibvspcnqr-sudo-1.8.25p1/sbin
patching script interpreter paths in /nix/store/0ffykrzff0s2zkhgzp2qbkdibvspcnqr-sudo-1.8.25p1
checking for references to /build in /nix/store/0ffykrzff0s2zkhgzp2qbkdibvspcnqr-sudo-1.8.25p1...
moving /nix/store/0ffykrzff0s2zkhgzp2qbkdibvspcnqr-sudo-1.8.25p1/sbin/* to /nix/store/0ffykrzff0s2zkhgzp2qbkdibvspcnqr-sudo-1.8.25p1/bin
/nix/store/0ffykrzff0s2zkhgzp2qbkdibvspcnqr-sudo-1.8.25p1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sudo

Partial log (click to expand)

shrinking /nix/store/b4pwf70v34vz16jx57pxg9y79g319mrs-sudo-1.8.25p1/libexec/sudo/sudoers.so
shrinking /nix/store/b4pwf70v34vz16jx57pxg9y79g319mrs-sudo-1.8.25p1/libexec/sudo/group_file.so
shrinking /nix/store/b4pwf70v34vz16jx57pxg9y79g319mrs-sudo-1.8.25p1/libexec/sudo/libsudo_util.so.0.0.0
gzipping man pages under /nix/store/b4pwf70v34vz16jx57pxg9y79g319mrs-sudo-1.8.25p1/share/man/
strip is /nix/store/671cv9iar3sh3icjq4vhi9msk4hp2x0z-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/b4pwf70v34vz16jx57pxg9y79g319mrs-sudo-1.8.25p1/libexec  /nix/store/b4pwf70v34vz16jx57pxg9y79g319mrs-sudo-1.8.25p1/bin  /nix/store/b4pwf70v34vz16jx57pxg9y79g319mrs-sudo-1.8.25p1/sbin
patching script interpreter paths in /nix/store/b4pwf70v34vz16jx57pxg9y79g319mrs-sudo-1.8.25p1
checking for references to /build in /nix/store/b4pwf70v34vz16jx57pxg9y79g319mrs-sudo-1.8.25p1...
moving /nix/store/b4pwf70v34vz16jx57pxg9y79g319mrs-sudo-1.8.25p1/sbin/* to /nix/store/b4pwf70v34vz16jx57pxg9y79g319mrs-sudo-1.8.25p1/bin
/nix/store/b4pwf70v34vz16jx57pxg9y79g319mrs-sudo-1.8.25p1

@Mic92 Mic92 added this to the 18.09 milestone Sep 15, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 15, 2018

Please also backport this.

@Mic92
Copy link
Member

Mic92 commented Sep 15, 2018

@GrahamcOfBorg test sudo

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: tests.sudo

Partial log (click to expand)

cannot build derivation '/nix/store/fbjz1qradpbjhiig97dixn07ha8qa41w-system-units.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/dr6k93000dygqjqdwi27rhk97p6c7z23-user-units.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/87zq6aq5zaibpv8znl537nqariq8r8mi-etc.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/0siqzfhpzshi54bbx03g8rgi6syya92b-nixos-system-machine-19.03.git.f3221a8.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/4wakisy0mzlwchqnnlys1wgdyi04fpld-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jb86vslzkw8la17b58034kprs95fiv7y-run-nixos-vm.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/g7k58ch66ami8mjxrhvhpk7i7a0d4zh2-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/hg80sqqsbhwy9v4amg4kgql74hjddvyk-nixos-test-driver-sudo.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/rz4psbn3qgr02rwxj2y39y2j6s22yick-vm-test-run-sudo.drv': 1 dependencies couldn't be built
error: build of '/nix/store/rz4psbn3qgr02rwxj2y39y2j6s22yick-vm-test-run-sudo.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: tests.sudo

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ca50a1vh74simin2gjj5q8z2v3sg9ai9-nixos-test-driver
strip is /nix/store/671cv9iar3sh3icjq4vhi9msk4hp2x0z-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ca50a1vh74simin2gjj5q8z2v3sg9ai9-nixos-test-driver/lib  /nix/store/ca50a1vh74simin2gjj5q8z2v3sg9ai9-nixos-test-driver/bin
patching script interpreter paths in /nix/store/ca50a1vh74simin2gjj5q8z2v3sg9ai9-nixos-test-driver
/nix/store/ca50a1vh74simin2gjj5q8z2v3sg9ai9-nixos-test-driver/bin/.nixos-test-driver-wrapped: interpreter directive changed from " /somewhere/perl -w" to "/nix/store/my23gm31ljg4y3ipaz31v2zw277r36pc-perl-5.28.0/bin/perl -w"
checking for references to /build in /nix/store/ca50a1vh74simin2gjj5q8z2v3sg9ai9-nixos-test-driver...
cannot build derivation '/nix/store/867vwr39icbdxkzpxzx7v0w5sq68y3n2-nixos-test-driver-sudo.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qmvywaqw951fx935bd148wbgsxjf7lx3-vm-test-run-sudo.drv': 1 dependencies couldn't be built
error: build of '/nix/store/qmvywaqw951fx935bd148wbgsxjf7lx3-vm-test-run-sudo.drv' failed

@Mic92
Copy link
Member

Mic92 commented Sep 17, 2018

Does this really need staging?

@xeji
Copy link
Contributor

xeji commented Sep 18, 2018

Master is still on 1.8.24, the update to 1.8.25 is in staging for whatever reason (not even staging-next yet). We could revert it on staging and do 1.8.24 -> 1.8.25p1 on master instead.

@dtzWill
Copy link
Member Author

dtzWill commented Sep 19, 2018

Oh I expected more to depend on this, sorry. Please proceed as seems best! I'm good with either approach.

@xeji
Copy link
Contributor

xeji commented Sep 19, 2018

@xeji xeji closed this Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
18.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @GrahamcOfBorg @Mic92 @xeji