Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh: 5.6.1 -> 5.6.2 #46683

Merged
merged 1 commit into from Sep 15, 2018
Merged

zsh: 5.6.1 -> 5.6.2 #46683

merged 1 commit into from Sep 15, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 15, 2018

From upstream's NEWS:

Changes from 5.6.1 to 5.6.2

Fix another SIGTTOU case.

Fix SIGWINCH being ignored when zsh is not in the foreground.

The release tarballs are now compressed using xz(1), whereas previously
both xz(1) and gzip(1) versions were available. If this gets in your way,
give us a shout.

This fixed an issue that was driving me crazy trying to isolate,
but may not happen to everyone.

FWIW, it's basically exactly what you expect from the description above
(so I was very excited when saw the commits leading to this release!)
but I'll explain briefly in case anyone else encountered it:

  1. Terminal running vim
  2. Resize terminal
  3. Exit vim
  4. WTF my shell's RPROMPT is aligned wrong and various things
    (completion, etc.) are borked. What gives?!

Anyway, hope this helps! :)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

From upstream's NEWS:

> Changes from 5.6.1 to 5.6.2
> ---------------------------
>
> Fix another SIGTTOU case.
>
> Fix SIGWINCH being ignored when zsh is not in the foreground.
>
> The release tarballs are now compressed using xz(1), whereas previously
> both xz(1) and gzip(1) versions were available.  If this gets in your way,
> give us a shout.
>
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: zsh

Partial log (click to expand)

shrinking /nix/store/ia8kkrzlmqy91wc3vpzj5x2vw1hyr8dd-zsh-5.6.2/lib/zsh/5.6.2/zsh/pcre.so
shrinking /nix/store/ia8kkrzlmqy91wc3vpzj5x2vw1hyr8dd-zsh-5.6.2/lib/zsh/5.6.2/zsh/system.so
shrinking /nix/store/ia8kkrzlmqy91wc3vpzj5x2vw1hyr8dd-zsh-5.6.2/lib/zsh/5.6.2/zsh/compctl.so
gzipping man pages under /nix/store/ia8kkrzlmqy91wc3vpzj5x2vw1hyr8dd-zsh-5.6.2/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ia8kkrzlmqy91wc3vpzj5x2vw1hyr8dd-zsh-5.6.2/lib  /nix/store/ia8kkrzlmqy91wc3vpzj5x2vw1hyr8dd-zsh-5.6.2/bin
patching script interpreter paths in /nix/store/ia8kkrzlmqy91wc3vpzj5x2vw1hyr8dd-zsh-5.6.2
/nix/store/ia8kkrzlmqy91wc3vpzj5x2vw1hyr8dd-zsh-5.6.2/share/zsh/5.6.2/functions/harden: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/ia8kkrzlmqy91wc3vpzj5x2vw1hyr8dd-zsh-5.6.2...
/nix/store/ia8kkrzlmqy91wc3vpzj5x2vw1hyr8dd-zsh-5.6.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: zsh

Partial log (click to expand)

fi
mkdir -m 755 -p -- /nix/store/fdqzr36p265yv0s47zs713z1zbdyimjw-zsh-5.6.2/share/zsh/5.6.2/help
make[1]: Leaving directory '/private/tmp/nix-build-zsh-5.6.2.drv-0/zsh-5.6.2/Doc'
post-installation fixup
gzipping man pages under /nix/store/fdqzr36p265yv0s47zs713z1zbdyimjw-zsh-5.6.2/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/fdqzr36p265yv0s47zs713z1zbdyimjw-zsh-5.6.2/lib  /nix/store/fdqzr36p265yv0s47zs713z1zbdyimjw-zsh-5.6.2/bin
patching script interpreter paths in /nix/store/fdqzr36p265yv0s47zs713z1zbdyimjw-zsh-5.6.2
/nix/store/fdqzr36p265yv0s47zs713z1zbdyimjw-zsh-5.6.2/share/zsh/5.6.2/functions/harden: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/fdqzr36p265yv0s47zs713z1zbdyimjw-zsh-5.6.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: zsh

Partial log (click to expand)

shrinking /nix/store/aq4cp5p70ndjk3vjm9hyys8k1xqlpr8l-zsh-5.6.2/lib/zsh/5.6.2/zsh/rlimits.so
shrinking /nix/store/aq4cp5p70ndjk3vjm9hyys8k1xqlpr8l-zsh-5.6.2/bin/zsh
shrinking /nix/store/aq4cp5p70ndjk3vjm9hyys8k1xqlpr8l-zsh-5.6.2/bin/zsh-5.6.2
gzipping man pages under /nix/store/aq4cp5p70ndjk3vjm9hyys8k1xqlpr8l-zsh-5.6.2/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/aq4cp5p70ndjk3vjm9hyys8k1xqlpr8l-zsh-5.6.2/lib  /nix/store/aq4cp5p70ndjk3vjm9hyys8k1xqlpr8l-zsh-5.6.2/bin
patching script interpreter paths in /nix/store/aq4cp5p70ndjk3vjm9hyys8k1xqlpr8l-zsh-5.6.2
/nix/store/aq4cp5p70ndjk3vjm9hyys8k1xqlpr8l-zsh-5.6.2/share/zsh/5.6.2/functions/harden: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/aq4cp5p70ndjk3vjm9hyys8k1xqlpr8l-zsh-5.6.2...
/nix/store/aq4cp5p70ndjk3vjm9hyys8k1xqlpr8l-zsh-5.6.2

@srhb srhb merged commit f3afe7b into NixOS:master Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants