Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

findutils: disable a bogus test #46666

Closed
wants to merge 1 commit into from
Closed

findutils: disable a bogus test #46666

wants to merge 1 commit into from

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Sep 14, 2018

findutils fails to pass checkPhase on my Linux system that has a sysconf(_SC_OPEN_MAX) limit set. The test itself appears to be a common copypasta between gnu projects. Poking limits of available fd's is irrelevant to what findutils is designed to do, so I consider the test to be bogus.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@veprbl veprbl closed this Sep 14, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: findutils

Partial log (click to expand)

shrinking /nix/store/zwq9r65mysj9zrckh7fhhhqqdpr7b0dd-findutils-4.6.0/bin/find
shrinking /nix/store/zwq9r65mysj9zrckh7fhhhqqdpr7b0dd-findutils-4.6.0/bin/xargs
shrinking /nix/store/zwq9r65mysj9zrckh7fhhhqqdpr7b0dd-findutils-4.6.0/bin/locate
gzipping man pages under /nix/store/zwq9r65mysj9zrckh7fhhhqqdpr7b0dd-findutils-4.6.0/share/man/
strip is /nix/store/n9acaakxahkv1q3av11l93p7rgd4xqsf-bootstrap-tools/bin/strip
stripping (with command strip and flags -S) in /nix/store/zwq9r65mysj9zrckh7fhhhqqdpr7b0dd-findutils-4.6.0/libexec  /nix/store/zwq9r65mysj9zrckh7fhhhqqdpr7b0dd-findutils-4.6.0/bin
checking for references to /build in /nix/store/zwq9r65mysj9zrckh7fhhhqqdpr7b0dd-findutils-4.6.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/f5ayrcxb37dzdc35k63ns0qgxjknkjdl-findutils-4.6.0-info
strip is /nix/store/n9acaakxahkv1q3av11l93p7rgd4xqsf-bootstrap-tools/bin/strip
checking for references to /build in /nix/store/f5ayrcxb37dzdc35k63ns0qgxjknkjdl-findutils-4.6.0-info...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: findutils

Partial log (click to expand)

make[1]: Leaving directory '/private/tmp/nix-build-findutils-4.6.0.drv-0/findutils-4.6.0'
post-installation fixup
gzipping man pages under /nix/store/41ylz73hgqa2ksmwgz3cf3d2vqyz0b3b-findutils-4.6.0/share/man/
strip is /nix/store/2ws9cmamvr7xyvdg4d2nnd1bmr1zjrrq-bootstrap-tools/bin/strip
stripping (with command strip and flags -S) in /nix/store/41ylz73hgqa2ksmwgz3cf3d2vqyz0b3b-findutils-4.6.0/libexec  /nix/store/41ylz73hgqa2ksmwgz3cf3d2vqyz0b3b-findutils-4.6.0/bin
patching script interpreter paths in /nix/store/41ylz73hgqa2ksmwgz3cf3d2vqyz0b3b-findutils-4.6.0
/nix/store/41ylz73hgqa2ksmwgz3cf3d2vqyz0b3b-findutils-4.6.0/bin/updatedb: interpreter directive changed from " /bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
strip is /nix/store/2ws9cmamvr7xyvdg4d2nnd1bmr1zjrrq-bootstrap-tools/bin/strip
patching script interpreter paths in /nix/store/x20jd018s89alvy5p2qdmzqxmmlqr6q0-findutils-4.6.0-info
/nix/store/41ylz73hgqa2ksmwgz3cf3d2vqyz0b3b-findutils-4.6.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: findutils

Partial log (click to expand)

shrinking /nix/store/0fpghk30dwzqnwdhgaan07fzkr45c4wk-findutils-4.6.0/bin/xargs
shrinking /nix/store/0fpghk30dwzqnwdhgaan07fzkr45c4wk-findutils-4.6.0/bin/find
gzipping man pages under /nix/store/0fpghk30dwzqnwdhgaan07fzkr45c4wk-findutils-4.6.0/share/man/
strip is /nix/store/8zbl35kgg8v7gircl3pvy9027vslll1q-bootstrap-tools/bin/strip
stripping (with command strip and flags -S) in /nix/store/0fpghk30dwzqnwdhgaan07fzkr45c4wk-findutils-4.6.0/libexec  /nix/store/0fpghk30dwzqnwdhgaan07fzkr45c4wk-findutils-4.6.0/bin
checking for references to /build in /nix/store/0fpghk30dwzqnwdhgaan07fzkr45c4wk-findutils-4.6.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/g12918hkackdni1qbz8qv68x2gb5lmz4-findutils-4.6.0-info
strip is /nix/store/8zbl35kgg8v7gircl3pvy9027vslll1q-bootstrap-tools/bin/strip
checking for references to /build in /nix/store/g12918hkackdni1qbz8qv68x2gb5lmz4-findutils-4.6.0-info...
/nix/store/0fpghk30dwzqnwdhgaan07fzkr45c4wk-findutils-4.6.0

@veprbl veprbl deleted the findutils_fix branch September 15, 2018 20:38
@veprbl veprbl restored the findutils_fix branch December 1, 2020 16:49
@veprbl veprbl deleted the findutils_fix branch December 1, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @GrahamcOfBorg