Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

kmsxx, kmscube: 2017-10-10 -> 2018-09-10, 2017-03-19 -> 2018-06-17 #46681

Merged
merged 2 commits into from Sep 15, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 15, 2018

Revisiting KMS and noticed these were a bit old and seemed like updates were a good idea! :)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • Tested execution of at least some of the programs 馃槆
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Various improvements -- if nothing else the 'kmstest'
utility now explains properly when permissions problem :).
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: kmscube, kmsxx

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kmscube, kmsxx

Partial log (click to expand)

shrinking /nix/store/6gqlnbkw16i2l72dnn0nn8dpwskrbza3-kmsxx-2018-09-10/bin/fbtest
shrinking /nix/store/6gqlnbkw16i2l72dnn0nn8dpwskrbza3-kmsxx-2018-09-10/bin/kmsprint
shrinking /nix/store/6gqlnbkw16i2l72dnn0nn8dpwskrbza3-kmsxx-2018-09-10/bin/kmstest
shrinking /nix/store/6gqlnbkw16i2l72dnn0nn8dpwskrbza3-kmsxx-2018-09-10/lib/python2.7/site-packages/pykms/pykms.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6gqlnbkw16i2l72dnn0nn8dpwskrbza3-kmsxx-2018-09-10/lib  /nix/store/6gqlnbkw16i2l72dnn0nn8dpwskrbza3-kmsxx-2018-09-10/bin
patching script interpreter paths in /nix/store/6gqlnbkw16i2l72dnn0nn8dpwskrbza3-kmsxx-2018-09-10
checking for references to /build in /nix/store/6gqlnbkw16i2l72dnn0nn8dpwskrbza3-kmsxx-2018-09-10...
/nix/store/h36jkkcp5mq24bzrfagz8a2kj30iv9s8-kmscube-2018-06-17
/nix/store/6gqlnbkw16i2l72dnn0nn8dpwskrbza3-kmsxx-2018-09-10

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kmscube, kmsxx

Partial log (click to expand)

shrinking /nix/store/xa7zavyiggbq3iy8gi73lpiww1g5fsrr-kmsxx-2018-09-10/bin/fbtest
shrinking /nix/store/xa7zavyiggbq3iy8gi73lpiww1g5fsrr-kmsxx-2018-09-10/bin/kmsprint
shrinking /nix/store/xa7zavyiggbq3iy8gi73lpiww1g5fsrr-kmsxx-2018-09-10/bin/kmstest
shrinking /nix/store/xa7zavyiggbq3iy8gi73lpiww1g5fsrr-kmsxx-2018-09-10/lib/python2.7/site-packages/pykms/pykms.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xa7zavyiggbq3iy8gi73lpiww1g5fsrr-kmsxx-2018-09-10/lib  /nix/store/xa7zavyiggbq3iy8gi73lpiww1g5fsrr-kmsxx-2018-09-10/bin
patching script interpreter paths in /nix/store/xa7zavyiggbq3iy8gi73lpiww1g5fsrr-kmsxx-2018-09-10
checking for references to /build in /nix/store/xa7zavyiggbq3iy8gi73lpiww1g5fsrr-kmsxx-2018-09-10...
/nix/store/h2m9kc2vahf9pf8bdn4ank29rm0vdkjw-kmscube-2018-06-17
/nix/store/xa7zavyiggbq3iy8gi73lpiww1g5fsrr-kmsxx-2018-09-10

@srhb srhb merged commit 7a36046 into NixOS:master Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants