Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.grv: fix darwin build by using go 1.9 #46664

Merged
merged 1 commit into from Sep 14, 2018
Merged

gitAndTools.grv: fix darwin build by using go 1.9 #46664

merged 1 commit into from Sep 14, 2018

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Sep 14, 2018 •
edited

cf. fsnotify/fsevents#40

/cc ZHF #45961

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Sep 14, 2018

@GrahamcOfBorg build gitAndTools.grv

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitAndTools.grv

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gx9wylbf7kck3wpxk8slyz5hqgcggp7i-grv-0.2.0-bin
shrinking /nix/store/gx9wylbf7kck3wpxk8slyz5hqgcggp7i-grv-0.2.0-bin/bin/grv
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gx9wylbf7kck3wpxk8slyz5hqgcggp7i-grv-0.2.0-bin/bin
patching script interpreter paths in /nix/store/gx9wylbf7kck3wpxk8slyz5hqgcggp7i-grv-0.2.0-bin
checking for references to /build in /nix/store/gx9wylbf7kck3wpxk8slyz5hqgcggp7i-grv-0.2.0-bin...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/gx9wylbf7kck3wpxk8slyz5hqgcggp7i-grv-0.2.0-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gitAndTools.grv

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vq9g43mwhwgxx6i2bgsvnhxb3zw1iqap-grv-0.2.0-bin
shrinking /nix/store/vq9g43mwhwgxx6i2bgsvnhxb3zw1iqap-grv-0.2.0-bin/bin/grv
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vq9g43mwhwgxx6i2bgsvnhxb3zw1iqap-grv-0.2.0-bin/bin
patching script interpreter paths in /nix/store/vq9g43mwhwgxx6i2bgsvnhxb3zw1iqap-grv-0.2.0-bin
checking for references to /build in /nix/store/vq9g43mwhwgxx6i2bgsvnhxb3zw1iqap-grv-0.2.0-bin...
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
/nix/store/vq9g43mwhwgxx6i2bgsvnhxb3zw1iqap-grv-0.2.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gitAndTools.grv

Partial log (click to expand)

find: '/nix/store/a93rcz47invihycifllaam9lx0l812sh-grv-0.2.0': No such file or directory
find: '/nix/store/a93rcz47invihycifllaam9lx0l812sh-grv-0.2.0': No such file or directory
find: '/nix/store/a93rcz47invihycifllaam9lx0l812sh-grv-0.2.0': No such file or directory
find: '/nix/store/a93rcz47invihycifllaam9lx0l812sh-grv-0.2.0': No such file or directory
find: '/nix/store/a93rcz47invihycifllaam9lx0l812sh-grv-0.2.0': No such file or directory
find: '/nix/store/a93rcz47invihycifllaam9lx0l812sh-grv-0.2.0': No such file or directory
find: '/nix/store/a93rcz47invihycifllaam9lx0l812sh-grv-0.2.0': No such file or directory
find: '/nix/store/a93rcz47invihycifllaam9lx0l812sh-grv-0.2.0': No such file or directory
find: '/nix/store/a93rcz47invihycifllaam9lx0l812sh-grv-0.2.0': No such file or directory
/nix/store/mvwqzxryg44x7kq6idgaqy3wnf2a6y6n-grv-0.2.0-bin

LnL7
LnL7 approved these changes Sep 14, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LnL7 LnL7 merged commit 3442408 into NixOS:master Sep 14, 2018
@mbode mbode deleted the grv_darwin branch September 15, 2018 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbode @LnL7 @GrahamcOfBorg