Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flink: 1.5 -> 1.6 #46659

Merged
merged 3 commits into from Sep 15, 2018
Merged

flink: 1.5 -> 1.6 #46659

merged 3 commits into from Sep 15, 2018

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Sep 14, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 15, 2018

Why do we need to keep 4 versions of this in nixpkgs?
According to upstream https://flink.apache.org/downloads.html#update-policy-for-old-releases :

As of March 2017, the Flink community decided to support the current and previous minor release with bugfixes. If 1.2.x is the current release, 1.1.y is the previous minor supported release. Both versions will receive bugfixes for critical issues.

So IMO we should keep 1.5.3 and 1.6.0, and drop the older versions.

@mbode mbode mentioned this pull request Sep 15, 2018
Merged
9 tasks
@xeji
Copy link
Contributor

xeji commented Sep 15, 2018

@GrahamcOfBorg build flink flink_1_5

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: flink, flink_1_5

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: flink, flink_1_5

Partial log (click to expand)

/nix/store/fj3as4jizz6vj6aw87z79ga34qrq40li-flink-1.6.0/opt/flink/bin/taskmanager.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/fj3as4jizz6vj6aw87z79ga34qrq40li-flink-1.6.0/opt/flink/bin/flink: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/fj3as4jizz6vj6aw87z79ga34qrq40li-flink-1.6.0/opt/flink/bin/jobmanager.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/fj3as4jizz6vj6aw87z79ga34qrq40li-flink-1.6.0/opt/flink/bin/start-zookeeper-quorum.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/fj3as4jizz6vj6aw87z79ga34qrq40li-flink-1.6.0/opt/flink/bin/yarn-session.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/fj3as4jizz6vj6aw87z79ga34qrq40li-flink-1.6.0/opt/flink/bin/standalone-job.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/fj3as4jizz6vj6aw87z79ga34qrq40li-flink-1.6.0/opt/flink/bin/flink-console.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/fj3as4jizz6vj6aw87z79ga34qrq40li-flink-1.6.0...
/nix/store/fj3as4jizz6vj6aw87z79ga34qrq40li-flink-1.6.0
/nix/store/ax6vihipmwyx5c8clpj48wi41nkah493-flink-1.5.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: flink, flink_1_5

Partial log (click to expand)

/nix/store/c1j1pasp2bnzbx7zkywmgyp8h7nm2bwj-flink-1.6.0/opt/flink/bin/start-cluster.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/c1j1pasp2bnzbx7zkywmgyp8h7nm2bwj-flink-1.6.0/opt/flink/bin/start-scala-shell.sh: interpreter directive changed from "/bin/bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/c1j1pasp2bnzbx7zkywmgyp8h7nm2bwj-flink-1.6.0/opt/flink/bin/start-zookeeper-quorum.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/c1j1pasp2bnzbx7zkywmgyp8h7nm2bwj-flink-1.6.0/opt/flink/bin/stop-cluster.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/c1j1pasp2bnzbx7zkywmgyp8h7nm2bwj-flink-1.6.0/opt/flink/bin/stop-zookeeper-quorum.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/c1j1pasp2bnzbx7zkywmgyp8h7nm2bwj-flink-1.6.0/opt/flink/bin/taskmanager.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/c1j1pasp2bnzbx7zkywmgyp8h7nm2bwj-flink-1.6.0/opt/flink/bin/yarn-session.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/c1j1pasp2bnzbx7zkywmgyp8h7nm2bwj-flink-1.6.0/opt/flink/bin/zookeeper.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/c1j1pasp2bnzbx7zkywmgyp8h7nm2bwj-flink-1.6.0
/nix/store/xdb2vw9ypwjxhkf7p9w2mm17akizv9ym-flink-1.5.3

@xeji xeji merged commit b917bb9 into NixOS:master Sep 15, 2018
@mbode mbode deleted the flink_1_6 branch September 15, 2018 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbode @xeji @GrahamcOfBorg