Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geis: fix build #46663

Merged
merged 1 commit into from Sep 14, 2018
Merged

geis: fix build #46663

merged 1 commit into from Sep 14, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 14, 2018

Motivation for this change

ZHF #45960.
Disable format hardening, ignore some compiler warnings

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
geis: fix build
c881ab5 
disable format hardening, ignore some compiler warnings
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: geis

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: geis

Partial log (click to expand)

shrinking /nix/store/m4fbscdwxs2mhy0z2yvn9mj6cxy5372b-geis-2.2.17/lib/python3.6/site-packages/_geis_bindings.so
shrinking /nix/store/m4fbscdwxs2mhy0z2yvn9mj6cxy5372b-geis-2.2.17/lib/libgeis.so.1.3.0
gzipping man pages under /nix/store/m4fbscdwxs2mhy0z2yvn9mj6cxy5372b-geis-2.2.17/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m4fbscdwxs2mhy0z2yvn9mj6cxy5372b-geis-2.2.17/lib  /nix/store/m4fbscdwxs2mhy0z2yvn9mj6cxy5372b-geis-2.2.17/bin
patching script interpreter paths in /nix/store/m4fbscdwxs2mhy0z2yvn9mj6cxy5372b-geis-2.2.17
/nix/store/m4fbscdwxs2mhy0z2yvn9mj6cxy5372b-geis-2.2.17/bin/.geisview-wrapped: interpreter directive changed from "/usr/bin/python3" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python3"
/nix/store/m4fbscdwxs2mhy0z2yvn9mj6cxy5372b-geis-2.2.17/bin/.pygeis-wrapped: interpreter directive changed from "/usr/bin/python3" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/m4fbscdwxs2mhy0z2yvn9mj6cxy5372b-geis-2.2.17...
/nix/store/m4fbscdwxs2mhy0z2yvn9mj6cxy5372b-geis-2.2.17

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: geis

Partial log (click to expand)

shrinking /nix/store/3k6m8d2xqx300pph361l31mrkyl3cm67-geis-2.2.17/lib/python3.6/site-packages/_geis_bindings.so
shrinking /nix/store/3k6m8d2xqx300pph361l31mrkyl3cm67-geis-2.2.17/lib/libgeis.so.1.3.0
gzipping man pages under /nix/store/3k6m8d2xqx300pph361l31mrkyl3cm67-geis-2.2.17/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3k6m8d2xqx300pph361l31mrkyl3cm67-geis-2.2.17/lib  /nix/store/3k6m8d2xqx300pph361l31mrkyl3cm67-geis-2.2.17/bin
patching script interpreter paths in /nix/store/3k6m8d2xqx300pph361l31mrkyl3cm67-geis-2.2.17
/nix/store/3k6m8d2xqx300pph361l31mrkyl3cm67-geis-2.2.17/bin/.pygeis-wrapped: interpreter directive changed from "/usr/bin/python3" to "/nix/store/sb88r9crdhinhkm6vpxwzf5zmij86p8v-python3-3.6.6/bin/python3"
/nix/store/3k6m8d2xqx300pph361l31mrkyl3cm67-geis-2.2.17/bin/.geisview-wrapped: interpreter directive changed from "/usr/bin/python3" to "/nix/store/sb88r9crdhinhkm6vpxwzf5zmij86p8v-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/3k6m8d2xqx300pph361l31mrkyl3cm67-geis-2.2.17...
/nix/store/3k6m8d2xqx300pph361l31mrkyl3cm67-geis-2.2.17

@xeji xeji merged commit 57ee141 into NixOS:master Sep 14, 2018
@xeji xeji deleted the p/geis branch September 14, 2018 21:58
xeji added a commit that referenced this pull request Sep 14, 2018
@xeji
geis: fix build (#46663)
0da7a40 
disable format hardening, ignore some compiler warnings

(cherry picked from commit 57ee141)
@xeji
Copy link
Contributor Author

xeji commented Sep 14, 2018

backported: 0da7a40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeji @GrahamcOfBorg