nginx, postgresql: give corresponding groups permission to read #46670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success on x86_64-linux (full log) Attempted: nginx, postgresql Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: nginx, postgresql Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: nginx, postgresql Partial log (click to expand)
|
Mic92
reviewed
Sep 14, 2018
| @@ -208,7 +208,7 @@ in | |||
| '' | |||
| # Create data directory. | |||
| if ! test -e ${cfg.dataDir}/PG_VERSION; then | |||
| mkdir -m 0700 -p ${cfg.dataDir} | |||
| mkdir -m 0750 -p ${cfg.dataDir} | |||
There was a problem hiding this comment.
This does not affect existing systems though. I would also add a chown without recursion below the if block.
There was a problem hiding this comment.
Sadly postgresql doesn't like it: FATAL: data directory "/var/db/postgresql-10.0" has group or world access
There was a problem hiding this comment.
You could probably work around with posix acls, but this is not something we can do in general.
|
I've worked around the problem of PG with a hack: They must have fixed this problem in PG11 (https://paquier.xyz/postgresql-2/postgres-11-group-access/) |
|
Closing this, as |
danbst
added a commit
to danbst/nixpkgs
that referenced
this pull request
Jul 23, 2019
This is rework of part of NixOS#46670. My usecase was to be able to inspect PG datadir as wheel user. PG11 now allows starting server with 0750 mask for data dir. `groupAccess = true` now does this automatically. The only thing you have to do is to set group ownership. For PG10 and below, I've described a hack how this can be done. Before this PR hack was impossible. The hack isn't ideal, because there is short period of time when dir mode is 0700, so I didn't want to make it official. Test/example is present too.
danbst
added a commit
that referenced
this pull request
Feb 14, 2020
* nixos/postgresql: support 0750 for data directory This is rework of part of #46670. My usecase was to be able to inspect PG datadir as wheel user. PG11 now allows starting server with 0750 mask for data dir. `groupAccess = true` now does this automatically. The only thing you have to do is to set group ownership. For PG10 and below, I've described a hack how this can be done. Before this PR hack was impossible. The hack isn't ideal, because there is short period of time when dir mode is 0700, so I didn't want to make it official. Test/example is present too. * postgresql: allow changing initidb arguments via module system Closes #18829 + some cleanups * addressed review comments and some fixes * whoops * change groupAccess to tristate, to not force `chmod` on dataDir. Making mask either 0700 or 0750 is too restrictive.. * WIP * let's not support group mode for versions pre-11. The only fix is to change mode to 0700 before start, because otherwise postgresql doesn't start, and error is non-obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation here is that I'd like to add
datadoguser topostgresandnginxgroups, which would allow datadog to read logs. I was actually the one that added exiting permissions to nginx back in 2013 and postgresql seems to date back to even svn in 2009.