Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compton{,-git}: bump to v2, set COMPTON_VERSION so '--version' has sane output #46685

Merged
merged 1 commit into from Sep 20, 2018
Merged

compton{,-git}: bump to v2, set COMPTON_VERSION so '--version' has sane output #46685

merged 1 commit into from Sep 20, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 15, 2018

Previously they both would claim to be 'git--' :).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
compton{,-git}: bump to v2, set COMPTON_VERSION so '--version' has sa…
387eed5 
…ne output

Previously they both would claim to be 'git--' :).
@xeji
Copy link
Contributor

xeji commented Sep 15, 2018

@GrahamcOfBorg build compton compton-git

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: compton, compton-git

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: compton, compton-git

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/9r8cp2i5r5j19wxz3w1sc97k2mm1ifqp-compton-git-2
shrinking /nix/store/9r8cp2i5r5j19wxz3w1sc97k2mm1ifqp-compton-git-2/bin/compton
gzipping man pages under /nix/store/9r8cp2i5r5j19wxz3w1sc97k2mm1ifqp-compton-git-2/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9r8cp2i5r5j19wxz3w1sc97k2mm1ifqp-compton-git-2/bin
patching script interpreter paths in /nix/store/9r8cp2i5r5j19wxz3w1sc97k2mm1ifqp-compton-git-2
/nix/store/9r8cp2i5r5j19wxz3w1sc97k2mm1ifqp-compton-git-2/bin/.compton-trans-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/9r8cp2i5r5j19wxz3w1sc97k2mm1ifqp-compton-git-2...
/nix/store/5kxzmpb9vjk6m6i5c3qwy00n2bc46c8r-compton-0.1_beta2.5
/nix/store/9r8cp2i5r5j19wxz3w1sc97k2mm1ifqp-compton-git-2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: compton, compton-git

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/vy2qpw5hw43wiw6a0cf2mb7ik6n53nj6-compton-git-2
shrinking /nix/store/vy2qpw5hw43wiw6a0cf2mb7ik6n53nj6-compton-git-2/bin/compton
gzipping man pages under /nix/store/vy2qpw5hw43wiw6a0cf2mb7ik6n53nj6-compton-git-2/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vy2qpw5hw43wiw6a0cf2mb7ik6n53nj6-compton-git-2/bin
patching script interpreter paths in /nix/store/vy2qpw5hw43wiw6a0cf2mb7ik6n53nj6-compton-git-2
/nix/store/vy2qpw5hw43wiw6a0cf2mb7ik6n53nj6-compton-git-2/bin/.compton-trans-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/vy2qpw5hw43wiw6a0cf2mb7ik6n53nj6-compton-git-2...
/nix/store/j32axrzd2pjip4v2rfxgnzd5qmdz8pjx-compton-0.1_beta2.5
/nix/store/vy2qpw5hw43wiw6a0cf2mb7ik6n53nj6-compton-git-2

@xeji
Copy link
Contributor

xeji commented Sep 15, 2018

I don't think this is what you want 😄 :

/nix/store/j32axrzd2pjip4v2rfxgnzd5qmdz8pjx-compton-0.1_beta2.5
/nix/store/vy2qpw5hw43wiw6a0cf2mb7ik6n53nj6-compton-git-2

@dtzWill
Copy link
Member Author

dtzWill commented Sep 20, 2018

I think those paths are right? Well assuming we call the maintenance fork compton-git even with tagged releases, but I figured just keep name what it was.

Or am I missing something? :3

@xeji
Copy link
Contributor

xeji commented Sep 20, 2018

Sorry, my mistake. I got confused by compton-git having a tagged release.

@xeji xeji merged commit 2eed7b7 into NixOS:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @xeji @GrahamcOfBorg