Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firmware-linux-nonfree: 2018-03-20 -> 2018-08-25 #45896

Merged
merged 1 commit into from Sep 1, 2018
Merged

firmware-linux-nonfree: 2018-03-20 -> 2018-08-25 #45896

merged 1 commit into from Sep 1, 2018

Conversation

ashkitten
Copy link
Contributor

Motivation for this change

the package was pretty outdated and may have been the cause of some issues i experienced before while running arch that disappeared after a while, but reappeared once i switched to nixos. no idea if this actually fixes the issue yet, since it's pretty random when it occurs, but it can't really hurt to update it anyways.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

vcunat
vcunat approved these changes Sep 1, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc maintainer @fpletz.

@xeji
Copy link
Contributor

xeji commented Sep 1, 2018

for the record: build checked locally

@vcunat
Copy link
Member

vcunat commented Sep 1, 2018

I had done that too, but almost nothing else.

@fpletz
Copy link
Member

fpletz commented Sep 1, 2018

Unfortunately, there's really nothing more to test other than checking if your particular hardware still works with the updated firmware. I've also checked the git history and haven't found anything that would prevent us from merging. Thanks!

@fpletz fpletz merged commit cdb244a into NixOS:master Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ashkitten @xeji @vcunat @fpletz @GrahamcOfBorg