Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbxml: move db62 to propagatedBuildInputs. #45878

Merged
merged 1 commit into from Sep 1, 2018
Merged

dbxml: move db62 to propagatedBuildInputs. #45878

merged 1 commit into from Sep 1, 2018

Conversation

danieldk
Copy link
Contributor

Some public DB XML headers include db.h from Berkeley DB. Move db62
to propagatedBuildInputs, to ensure that packages with a dependency
on dbxml, but without a dependency on db compile.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@danieldk
dbxml: move db62 to propagatedBuildInputs.
da42c63 
Some public DB XML headers include db.h from Berkeley DB. Move db62
to propagatedBuildInputs, to ensure that packages with a dependency
on dbxml, but without a dependency on db compile.
@xeji
Copy link
Contributor

xeji commented Sep 1, 2018

to ensure that packages with a dependency on dbxml, but without a dependency on db compile.

Did you encounter this issue with specific packages in nixpkgs?

@danieldk
Copy link
Contributor Author

danieldk commented Sep 1, 2018 •
edited

No, since the Haskell BerkeleyDBXML package (which I don't use) is currently the only package in nixpkgs that depends on dbxml.

However, we use dbxml in some of our own software. Here we explicitly need to specify db62 as a build input, even though our software does not use Berkeley DB directly, due to the db.h include in Berkeley DB XML's headers:

https://github.com/danieldk/nix-home/blob/bf745ff9ef3933ae9be717654d827aafe18a19c6/overlays/30-alpinocorpus.nix#L19

@xeji
Copy link
Contributor

xeji commented Sep 1, 2018

Thanks for explaining. LGTM.
@GrahamcOfBorg build dbxml

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: dbxml

Partial log (click to expand)

 /nix/store/zkfqg7icazgz0kj7rff6zdfbcf3v79sa-coreutils-8.29/bin/install -c -m 644 'include/dbxml/XmlTransaction.hpp' '/nix/store/rkdaflrinfd227xm4rgid61g009ycs8n-dbxml-6.1.4/include/dbxml/XmlTransaction.hpp'
 /nix/store/zkfqg7icazgz0kj7rff6zdfbcf3v79sa-coreutils-8.29/bin/install -c -m 644 'include/dbxml/XmlUpdateContext.hpp' '/nix/store/rkdaflrinfd227xm4rgid61g009ycs8n-dbxml-6.1.4/include/dbxml/XmlUpdateContext.hpp'
 /nix/store/zkfqg7icazgz0kj7rff6zdfbcf3v79sa-coreutils-8.29/bin/install -c -m 644 'include/dbxml/XmlValue.hpp' '/nix/store/rkdaflrinfd227xm4rgid61g009ycs8n-dbxml-6.1.4/include/dbxml/XmlValue.hpp'
test -z "" || /nix/store/zkfqg7icazgz0kj7rff6zdfbcf3v79sa-coreutils-8.29/bin/mkdir -p ""
make[1]: Leaving directory '/private/tmp/nix-build-dbxml-6.1.4.drv-0/dbxml-6.1.4/dbxml'
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/rkdaflrinfd227xm4rgid61g009ycs8n-dbxml-6.1.4/lib  /nix/store/rkdaflrinfd227xm4rgid61g009ycs8n-dbxml-6.1.4/bin
patching script interpreter paths in /nix/store/rkdaflrinfd227xm4rgid61g009ycs8n-dbxml-6.1.4
/nix/store/rkdaflrinfd227xm4rgid61g009ycs8n-dbxml-6.1.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dbxml

Partial log (click to expand)

shrinking /nix/store/bljzg9kff1rwvci2jis0fld53kzlfnbd-dbxml-6.1.4/lib/libdbxml-6.1.so
shrinking /nix/store/bljzg9kff1rwvci2jis0fld53kzlfnbd-dbxml-6.1.4/bin/dbxml
shrinking /nix/store/bljzg9kff1rwvci2jis0fld53kzlfnbd-dbxml-6.1.4/bin/dbxml_load
shrinking /nix/store/bljzg9kff1rwvci2jis0fld53kzlfnbd-dbxml-6.1.4/bin/dbxml_load_container
shrinking /nix/store/bljzg9kff1rwvci2jis0fld53kzlfnbd-dbxml-6.1.4/bin/dbxml_dump
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bljzg9kff1rwvci2jis0fld53kzlfnbd-dbxml-6.1.4/lib  /nix/store/bljzg9kff1rwvci2jis0fld53kzlfnbd-dbxml-6.1.4/bin
patching script interpreter paths in /nix/store/bljzg9kff1rwvci2jis0fld53kzlfnbd-dbxml-6.1.4
checking for references to /build in /nix/store/bljzg9kff1rwvci2jis0fld53kzlfnbd-dbxml-6.1.4...
/nix/store/bljzg9kff1rwvci2jis0fld53kzlfnbd-dbxml-6.1.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dbxml

Partial log (click to expand)

shrinking /nix/store/fy7qzjxjzdpmrgqv6jc7g6yjs9xfm115-dbxml-6.1.4/bin/dbxml_load_container
shrinking /nix/store/fy7qzjxjzdpmrgqv6jc7g6yjs9xfm115-dbxml-6.1.4/bin/dbxml_load
shrinking /nix/store/fy7qzjxjzdpmrgqv6jc7g6yjs9xfm115-dbxml-6.1.4/bin/dbxml_dump
shrinking /nix/store/fy7qzjxjzdpmrgqv6jc7g6yjs9xfm115-dbxml-6.1.4/bin/dbxml
shrinking /nix/store/fy7qzjxjzdpmrgqv6jc7g6yjs9xfm115-dbxml-6.1.4/lib/libdbxml-6.1.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fy7qzjxjzdpmrgqv6jc7g6yjs9xfm115-dbxml-6.1.4/lib  /nix/store/fy7qzjxjzdpmrgqv6jc7g6yjs9xfm115-dbxml-6.1.4/bin
patching script interpreter paths in /nix/store/fy7qzjxjzdpmrgqv6jc7g6yjs9xfm115-dbxml-6.1.4
checking for references to /build in /nix/store/fy7qzjxjzdpmrgqv6jc7g6yjs9xfm115-dbxml-6.1.4...
/nix/store/fy7qzjxjzdpmrgqv6jc7g6yjs9xfm115-dbxml-6.1.4

@xeji xeji merged commit 958bdc3 into NixOS:master Sep 1, 2018
@danieldk danieldk deleted the dbxml-dbdep branch September 5, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @xeji @GrahamcOfBorg