Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: edc13bae5462
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 2e7cb61cfbe6
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Aug 28, 2018

  1. coreutils nitpick: add --with-packager

    `tool --version` now gets additional line:
    Packaged by https://NixOS.org
    vcunat committed Aug 28, 2018
    Copy the full SHA
    85facc4 View commit details
    Browse the repository at this point in the history
  2. coreutils: split a coreutils-full version

    - default coreutils is stripped of /share/ (11 -> 2 MiB)
    - coreutils-full retains /share/ and adds openssl for faster *sum tools
    - NixOS systemPackages contains coreutils-full
    - *Support parameter defaults are moved inside
      (it seemed confusing to have `? false` and "at once" with `? isLinux`)
    
    Closure considerations:
    + typical build-time closure will get lighter by ~9 MiB
    - typical closure of NixOS installation will grow by ~2 MiB,
      due to referring to both versions.  I think it would be possible to
      re-use most of the utils between the two versions, but the expression
      would get much more complex.
    
    I considered having stdenv with minimal coreutils and the default
    `coreutils` attribute being full, but it turned out there were too many
    trivial references in nixpkgs, so it didn't seem easy to keep rebuild
    impact of openssl from growing significantly.
    vcunat committed Aug 28, 2018
    Copy the full SHA
    fd3927a View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2018

  1. Copy the full SHA
    2e7cb61 View commit details
    Browse the repository at this point in the history