Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qgis: patch for compatibility with cmake 3.12 #45880

Merged
merged 1 commit into from Sep 1, 2018
Merged

qgis: patch for compatibility with cmake 3.12 #45880

merged 1 commit into from Sep 1, 2018

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Work with cmake update in #44910. Reported upstream as qgis/QGIS#7765.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 31, 2018

@GrahamcOfBorg build qgis

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin [(full log)](https://logs.nix.ci/?key=nixos/nixpkgs.45880&attempt_id=63067855-408b-45ad-8fec-fbaf5608c8fa)

The following builds were skipped because they don't evaluate on x86_64-darwin: qgis

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@xeji
Copy link
Contributor

xeji commented Aug 31, 2018

@grahamc did you change the message format? Looks like there's a newline where there shouldn't be.

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: qgis

Partial log (click to expand)

patching script interpreter paths in /nix/store/n0i8xwarlvln6qxx7wmmb1b5y8d0qlg0-ffmpeg-3.4.4-man
checking for references to /build in /nix/store/n0i8xwarlvln6qxx7wmmb1b5y8d0qlg0-ffmpeg-3.4.4-man...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
Moving /nix/store/iq30872sn562w6733znbk5x256zawpmg-ffmpeg-3.4.4/bin to /nix/store/7qsw8pyzfmwc77xqjvgh3z7whdwq37h8-ffmpeg-3.4.4-bin/bin
rmdir: failed to remove '/nix/store/iq30872sn562w6733znbk5x256zawpmg-ffmpeg-3.4.4': Directory not empty
Moving /nix/store/iq30872sn562w6733znbk5x256zawpmg-ffmpeg-3.4.4/share/ffmpeg/examples to /nix/store/ji5w2lbz8v8plknwklqi49ysbjr7iv4r-ffmpeg-3.4.4-doc/share/ffmpeg/examples
rmdir: failed to remove '/nix/store/iq30872sn562w6733znbk5x256zawpmg-ffmpeg-3.4.4/share/ffmpeg': Directory not empty
cannot build derivation '/nix/store/8fp3npk18cgn6zh5nrr5ks6h2zzlza3v-grass-7.2.2.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/08f3g7n6a8bkjmpmszvkk39kh32bfqz8-qgis-2.18.22.drv': 8 dependencies couldn't be built
error: build of '/nix/store/08f3g7n6a8bkjmpmszvkk39kh32bfqz8-qgis-2.18.22.drv' failed

@xeji
Copy link
Contributor

xeji commented Aug 31, 2018

Well, it's a long build, so timeout is not surprising.

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: qgis

Partial log (click to expand)

wrapping `/nix/store/dv34r3hj3967jfx45kb7v4nv0lj9la42-python2.7-wxPython-3.0.2.0/bin/.pycrust-wrapped'...
wrapping `/nix/store/dv34r3hj3967jfx45kb7v4nv0lj9la42-python2.7-wxPython-3.0.2.0/bin/.pyalamode-wrapped'...
wrapping `/nix/store/dv34r3hj3967jfx45kb7v4nv0lj9la42-python2.7-wxPython-3.0.2.0/bin/.pyalacarte-wrapped'...
wrapping `/nix/store/dv34r3hj3967jfx45kb7v4nv0lj9la42-python2.7-wxPython-3.0.2.0/bin/.img2xpm-wrapped'...
wrapping `/nix/store/dv34r3hj3967jfx45kb7v4nv0lj9la42-python2.7-wxPython-3.0.2.0/bin/.img2py-wrapped'...
wrapping `/nix/store/dv34r3hj3967jfx45kb7v4nv0lj9la42-python2.7-wxPython-3.0.2.0/bin/.img2png-wrapped'...
wrapping `/nix/store/dv34r3hj3967jfx45kb7v4nv0lj9la42-python2.7-wxPython-3.0.2.0/bin/.helpviewer-wrapped'...
cannot build derivation '/nix/store/x7yjh29az56mj8yrrrqwrkhrlc3vdqjw-grass-7.2.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/lyym6nj6n25p3yfn44zwgc7v3r4lxvcz-qgis-2.18.22.drv': 8 dependencies couldn't be built
error: build of '/nix/store/lyym6nj6n25p3yfn44zwgc7v3r4lxvcz-qgis-2.18.22.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 1, 2018 •
edited

x86_64-linux build checked locally.

@xeji xeji merged commit 90464f6 into NixOS:staging Sep 1, 2018
@thefloweringash thefloweringash deleted the qgis-cmake-3.12 branch September 24, 2018 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thefloweringash @xeji @GrahamcOfBorg