Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.reason: remove spurious dependency on opam #45892

Merged
merged 1 commit into from Sep 1, 2018
Merged

ocamlPackages.reason: remove spurious dependency on opam #45892

merged 1 commit into from Sep 1, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 1, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Sep 1, 2018

@GrahamcOfBorg build reason

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: reason

Partial log (click to expand)

shrinking /nix/store/g34g0k294z7g7l417n637vmi930l2dds-ocaml4.06.1-reason-3.3.3/lib/ocaml/4.06.1/site-lib/rtop/rtop.cmxs
shrinking /nix/store/g34g0k294z7g7l417n637vmi930l2dds-ocaml4.06.1-reason-3.3.3/lib/ocaml/4.06.1/site-lib/reason/reason.cmxs
shrinking /nix/store/g34g0k294z7g7l417n637vmi930l2dds-ocaml4.06.1-reason-3.3.3/lib/ocaml/4.06.1/site-lib/reason/easy_format/reason.easy_format.cmxs
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/g34g0k294z7g7l417n637vmi930l2dds-ocaml4.06.1-reason-3.3.3/lib  /nix/store/g34g0k294z7g7l417n637vmi930l2dds-ocaml4.06.1-reason-3.3.3/bin
patching script interpreter paths in /nix/store/g34g0k294z7g7l417n637vmi930l2dds-ocaml4.06.1-reason-3.3.3
/nix/store/g34g0k294z7g7l417n637vmi930l2dds-ocaml4.06.1-reason-3.3.3/bin/.rtop-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/g34g0k294z7g7l417n637vmi930l2dds-ocaml4.06.1-reason-3.3.3/bin/rtop_init.ml: interpreter directive changed from "/usr/bin/env ocaml" to "/nix/store/qzsja41zxyp12x4w03djq3k3rhq8qzww-ocaml-4.06.1/bin/ocaml"
checking for references to /build in /nix/store/g34g0k294z7g7l417n637vmi930l2dds-ocaml4.06.1-reason-3.3.3...
/nix/store/g34g0k294z7g7l417n637vmi930l2dds-ocaml4.06.1-reason-3.3.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: reason

Partial log (click to expand)

shrinking /nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3/bin/reactjs_jsx_ppx_v2
shrinking /nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3/bin/testOprint
shrinking /nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3/bin/ocamlmerlin-reason
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3/lib  /nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3/bin
patching script interpreter paths in /nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3
/nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3/bin/rtop_init.ml: interpreter directive changed from "/usr/bin/env ocaml" to "/nix/store/plhkx3w0n3ad6kn40936ic73k6wx28fm-ocaml-4.06.1/bin/ocaml"
/nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3/bin/.rtop-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3...
/nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: reason

Partial log (click to expand)

Processing file reason.install as reason.
Processing file rtop.install as rtop.
post-installation fixup
moving /nix/store/hc9fxazm8vbwcwyghy60yzw8kdhsqp44-ocaml4.06.1-reason-3.3.3/doc to /nix/store/hc9fxazm8vbwcwyghy60yzw8kdhsqp44-ocaml4.06.1-reason-3.3.3/share/doc
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/hc9fxazm8vbwcwyghy60yzw8kdhsqp44-ocaml4.06.1-reason-3.3.3/lib  /nix/store/hc9fxazm8vbwcwyghy60yzw8kdhsqp44-ocaml4.06.1-reason-3.3.3/bin
patching script interpreter paths in /nix/store/hc9fxazm8vbwcwyghy60yzw8kdhsqp44-ocaml4.06.1-reason-3.3.3
/nix/store/hc9fxazm8vbwcwyghy60yzw8kdhsqp44-ocaml4.06.1-reason-3.3.3/bin/.rtop-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/hc9fxazm8vbwcwyghy60yzw8kdhsqp44-ocaml4.06.1-reason-3.3.3/bin/rtop_init.ml: interpreter directive changed from "/usr/bin/env ocaml" to "/nix/store/99sracn8p06w9lqpnx7aqysq268k5wmg-ocaml-4.06.1/bin/ocaml"
/nix/store/hc9fxazm8vbwcwyghy60yzw8kdhsqp44-ocaml4.06.1-reason-3.3.3

@Mic92
Copy link
Member

Mic92 commented Sep 1, 2018

@GrahamcOfBorg build ocamlPackages.reason

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ocamlPackages.reason

Partial log (click to expand)

/nix/store/g34g0k294z7g7l417n637vmi930l2dds-ocaml4.06.1-reason-3.3.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ocamlPackages.reason

Partial log (click to expand)

shrinking /nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3/bin/refmt
shrinking /nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3/bin/refmttype
shrinking /nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3/bin/ocamlmerlin-reason
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3/lib  /nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3/bin
patching script interpreter paths in /nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3
/nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3/bin/.rtop-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3/bin/rtop_init.ml: interpreter directive changed from "/usr/bin/env ocaml" to "/nix/store/plhkx3w0n3ad6kn40936ic73k6wx28fm-ocaml-4.06.1/bin/ocaml"
checking for references to /build in /nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3...
/nix/store/v3n3rzb73krg1a8gbjrx6wnlg8lc3hx5-ocaml4.06.1-reason-3.3.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ocamlPackages.reason

Partial log (click to expand)

/nix/store/hc9fxazm8vbwcwyghy60yzw8kdhsqp44-ocaml4.06.1-reason-3.3.3

@Mic92 Mic92 merged commit fbad0bc into NixOS:master Sep 1, 2018
@vbgl vbgl deleted the reason branch September 1, 2018 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @GrahamcOfBorg @Mic92