Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bluez: 5.48 -> 5.50 #45901

Merged
merged 1 commit into from Sep 2, 2018
Merged

bluez: 5.48 -> 5.50 #45901

merged 1 commit into from Sep 2, 2018

Conversation

jraygauthier
Copy link
Member

@jraygauthier jraygauthier commented Sep 1, 2018 •
edited

Fixes Bluetooth device not working after suspend regression.

Motivation for this change

As discussed in #41583 (comment)

Please merge as well to 18.03 (actually using bluez-5.48). This fixes Bluetooth device not working after suspend regression:

  • Bug 1534857 – bluez regression: Bluetooth audio fails to reconnect after resume

    I confirm that downgrading to bluez-5.47-2.fc27.x86_64 from bluez-5.48-1.fc27.x86_64 solved (temporarily) the issue.

    So far looks like bluez-5.48-2.fc27 fixes this on T470.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jraygauthier
bluez: 5.48 -> 5.50
0a7f483 
Fixes Bluetooth device not working after suspend regression.
@jraygauthier
Copy link
Member Author

@xeji : ping as requested

@xeji
Copy link
Contributor

xeji commented Sep 1, 2018

@GrahamcOfBorg build bluez

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: bluez

Partial log (click to expand)

Cannot nix-instantiate `bluez' because:
error: while evaluating 'callPackageWith' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:113:35, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:12965:12:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:72:24, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:117:8:
while evaluating anonymous function at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/bluez/default.nix:1:1, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:74:12:
assertion failed at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/bluez/default.nix:5:1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bluez

Partial log (click to expand)

/nix/store/qjs3r9z1a80v8v0rgq28dc962p9446wf-bluez-5.50-test/test/.list-devices-wrapped: interpreter directive changed from "/usr/bin/python" to "/nix/store/xy90bg50sp8ngd0vm8j2mw3knkj8i81s-python-2.7.15/bin/python"
/nix/store/qjs3r9z1a80v8v0rgq28dc962p9446wf-bluez-5.50-test/test/.test-sap-server-wrapped: interpreter directive changed from "/usr/bin/python" to "/nix/store/xy90bg50sp8ngd0vm8j2mw3knkj8i81s-python-2.7.15/bin/python"
/nix/store/qjs3r9z1a80v8v0rgq28dc962p9446wf-bluez-5.50-test/test/.simple-agent-wrapped: interpreter directive changed from "/usr/bin/python" to "/nix/store/xy90bg50sp8ngd0vm8j2mw3knkj8i81s-python-2.7.15/bin/python"
/nix/store/qjs3r9z1a80v8v0rgq28dc962p9446wf-bluez-5.50-test/test/.simple-endpoint-wrapped: interpreter directive changed from "/usr/bin/python" to "/nix/store/xy90bg50sp8ngd0vm8j2mw3knkj8i81s-python-2.7.15/bin/python"
/nix/store/qjs3r9z1a80v8v0rgq28dc962p9446wf-bluez-5.50-test/test/.test-hfp-wrapped: interpreter directive changed from "/usr/bin/python" to "/nix/store/xy90bg50sp8ngd0vm8j2mw3knkj8i81s-python-2.7.15/bin/python"
/nix/store/qjs3r9z1a80v8v0rgq28dc962p9446wf-bluez-5.50-test/test/.test-network-wrapped: interpreter directive changed from "/usr/bin/python" to "/nix/store/xy90bg50sp8ngd0vm8j2mw3knkj8i81s-python-2.7.15/bin/python"
/nix/store/qjs3r9z1a80v8v0rgq28dc962p9446wf-bluez-5.50-test/test/.opp-client-wrapped: interpreter directive changed from "/usr/bin/python" to "/nix/store/xy90bg50sp8ngd0vm8j2mw3knkj8i81s-python-2.7.15/bin/python"
/nix/store/qjs3r9z1a80v8v0rgq28dc962p9446wf-bluez-5.50-test/test/.simple-player-wrapped: interpreter directive changed from "/usr/bin/python" to "/nix/store/xy90bg50sp8ngd0vm8j2mw3knkj8i81s-python-2.7.15/bin/python"
checking for references to /build in /nix/store/qjs3r9z1a80v8v0rgq28dc962p9446wf-bluez-5.50-test...
/nix/store/b3qj5ya4jnzr6pq23277cmy48rq0ibjm-bluez-5.50

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bluez

Partial log (click to expand)

/nix/store/r3mn02cydkrajcxjwm7s0mz3a010kgy1-bluez-5.50-test/test/.test-health-wrapped: interpreter directive changed from "/usr/bin/python" to "/nix/store/fb993ma5m3y1hs95gay44j8mjjq5qlkl-python-2.7.15/bin/python"
/nix/store/r3mn02cydkrajcxjwm7s0mz3a010kgy1-bluez-5.50-test/test/.map-client-wrapped: interpreter directive changed from "/usr/bin/python" to "/nix/store/fb993ma5m3y1hs95gay44j8mjjq5qlkl-python-2.7.15/bin/python"
/nix/store/r3mn02cydkrajcxjwm7s0mz3a010kgy1-bluez-5.50-test/test/.simple-player-wrapped: interpreter directive changed from "/usr/bin/python" to "/nix/store/fb993ma5m3y1hs95gay44j8mjjq5qlkl-python-2.7.15/bin/python"
/nix/store/r3mn02cydkrajcxjwm7s0mz3a010kgy1-bluez-5.50-test/test/.test-adapter-wrapped: interpreter directive changed from "/usr/bin/python" to "/nix/store/fb993ma5m3y1hs95gay44j8mjjq5qlkl-python-2.7.15/bin/python"
/nix/store/r3mn02cydkrajcxjwm7s0mz3a010kgy1-bluez-5.50-test/test/.example-advertisement-wrapped: interpreter directive changed from "/usr/bin/python" to "/nix/store/fb993ma5m3y1hs95gay44j8mjjq5qlkl-python-2.7.15/bin/python"
/nix/store/r3mn02cydkrajcxjwm7s0mz3a010kgy1-bluez-5.50-test/test/.monitor-bluetooth-wrapped: interpreter directive changed from "/usr/bin/python" to "/nix/store/fb993ma5m3y1hs95gay44j8mjjq5qlkl-python-2.7.15/bin/python"
/nix/store/r3mn02cydkrajcxjwm7s0mz3a010kgy1-bluez-5.50-test/test/.test-nap-wrapped: interpreter directive changed from "/usr/bin/python" to "/nix/store/fb993ma5m3y1hs95gay44j8mjjq5qlkl-python-2.7.15/bin/python"
/nix/store/r3mn02cydkrajcxjwm7s0mz3a010kgy1-bluez-5.50-test/test/.test-sap-server-wrapped: interpreter directive changed from "/usr/bin/python" to "/nix/store/fb993ma5m3y1hs95gay44j8mjjq5qlkl-python-2.7.15/bin/python"
checking for references to /build in /nix/store/r3mn02cydkrajcxjwm7s0mz3a010kgy1-bluez-5.50-test...
/nix/store/z61fdavq5y3yfclzfc9zmz0r3difjpn2-bluez-5.50

@jraygauthier jraygauthier mentioned this pull request Sep 1, 2018
Closed
@xeji
Copy link
Contributor

xeji commented Sep 2, 2018

Let's check some packages that depend on it
@GrahamcOfBorg build networkmanager blueman bluez-tools obexd obexftp obex-data-server bluedevil

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: bluez-tools

The following builds were skipped because they don't evaluate on x86_64-darwin: networkmanager, blueman, obexd, obexftp, obex-data-server, bluedevil

Partial log (click to expand)

copying path '/nix/store/par11jqglj20k0v04q4zwws1y5iib7wd-ICU-osx-10.10.5' from 'https://cache.nixos.org'...
copying path '/nix/store/2fsjvcfgpl5hmv0bzfw406h1i9yh8wfn-pcre-8.41' from 'https://cache.nixos.org'...
copying path '/nix/store/8svsigh3vxziw2l15zhn7g64nsbjc1mh-CF-osx-10.10.5' from 'https://cache.nixos.org'...
copying path '/nix/store/z4r6z6nvajqx4vsgx16m2917gq50sach-zlib-1.2.11' from 'https://cache.nixos.org'...
copying path '/nix/store/74jmw1g1zirni1jw9psdc7s8qr7m1fm1-libiconv-osx-10.11.6' from 'https://cache.nixos.org'...
copying path '/nix/store/6mqhzdn3r4jfr8s3cjlizp93xnrqgjgp-readline-6.3p08' from 'https://cache.nixos.org'...
copying path '/nix/store/rwbnij5kwl4wr2r8x18v9pbb2bzry4la-gettext-0.19.8' from 'https://cache.nixos.org'...
copying path '/nix/store/ab4kcfgmgg4j9pk0kbfj3wgbwi4amrx5-glib-2.54.3' from 'https://cache.nixos.org'...
copying path '/nix/store/ldbpp3vlqrlnjgj0whvc9gsb7i3540ls-bluez-tools-2016-12-12' from 'https://cache.nixos.org'...
/nix/store/ldbpp3vlqrlnjgj0whvc9gsb7i3540ls-bluez-tools-2016-12-12

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: networkmanager, blueman, bluez-tools, obexd, obexftp, bluedevil

The following builds were skipped because they don't evaluate on x86_64-linux: obex-data-server

Partial log (click to expand)

strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/0d6d2l4avfc98yy223wskh5kla9fs00r-network-manager-1.10.2-dev/lib
patching script interpreter paths in /nix/store/0d6d2l4avfc98yy223wskh5kla9fs00r-network-manager-1.10.2-dev
checking for references to /build in /nix/store/0d6d2l4avfc98yy223wskh5kla9fs00r-network-manager-1.10.2-dev...
/nix/store/546l7faksa5lhv9gq6k0biigdgm6ykpi-network-manager-1.10.2
/nix/store/xzvvp8x8wsbd59hhas6l4bq0k0mdipfx-blueman-2.0.5
/nix/store/7ridcd1x6r4cmzrn6prva2wcdjz35sik-bluez-tools-2016-12-12
/nix/store/xi86vjr8j63ibj5brvbnfgj5vabj3vyr-obexd-0.48
/nix/store/vd8xwv4i4djwqzrqf92w5fxk9m20m0w6-obexftp-0.24
/nix/store/j3sxa5di8llrnrmkagpr4zz9zhrs80iq-bluedevil-5.12.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: networkmanager, blueman, bluez-tools, obexd, obexftp, bluedevil

The following builds were skipped because they don't evaluate on aarch64-linux: obex-data-server

Partial log (click to expand)

strip is /nix/store/hy39vplmzpwckvzxgyhr54dwz0mnfv2p-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/kkckjbfs4gpz15xgjlmmyc5r7gv0n330-network-manager-1.10.2-dev/lib
patching script interpreter paths in /nix/store/kkckjbfs4gpz15xgjlmmyc5r7gv0n330-network-manager-1.10.2-dev
checking for references to /build in /nix/store/kkckjbfs4gpz15xgjlmmyc5r7gv0n330-network-manager-1.10.2-dev...
/nix/store/i9qi7djrlhsayrq2agab4187nf40a3zi-network-manager-1.10.2
/nix/store/4hw6d1aps73ig4xb4hbxwk9qb4h7rzs1-blueman-2.0.5
/nix/store/naz6m8x1k97xi0hbp4by6pv23fkc6s04-bluez-tools-2016-12-12
/nix/store/96y9yghq4fdxlyd0xffkcxmvqkbr0dvv-obexd-0.48
/nix/store/gh3a67qp5ib9ivhn35mz9b6x8wrdslg6-obexftp-0.24
/nix/store/2q4abfw23ymqx73h9cq6v3b40f9ykndi-bluedevil-5.12.6

@xeji
Copy link
Contributor

xeji commented Sep 2, 2018

Release notes don't mention any breaking changes. https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/ChangeLog

xeji
xeji approved these changes Sep 2, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes a bug that probably affects many users

@xeji xeji merged commit 8b92a4e into NixOS:release-18.03 Sep 2, 2018
@jraygauthier
Copy link
Member Author

@xeji : Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jraygauthier @xeji @GrahamcOfBorg