Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjdk: 10.0.1 -> 10.0.2 #45881

Merged
merged 2 commits into from Aug 31, 2018
Merged

openjdk: 10.0.1 -> 10.0.2 #45881

merged 2 commits into from Aug 31, 2018

Conversation

andir
Copy link
Member

@andir andir commented Aug 31, 2018

Motivation for this change

this fixes a series of potential security issues:

CVE-2018-2940, CVE-2018-2941, CVE-2018-2952, CVE-2018-2964,
CVE-2018-2972 & CVE-2018-2973

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member Author

andir commented Aug 31, 2018

I am in the process of also updating the JDK10 for Darwin but that might still take a while until the machine is set up :/

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: openjdk10

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: openjdk10

Partial log (click to expand)

these paths will be fetched (165.71 MiB download, 320.44 MiB unpacked):
  /nix/store/90jrb626qmbf0is642wdc3zfdc625lx3-zulu10.1+11-jdk10
copying path '/nix/store/90jrb626qmbf0is642wdc3zfdc625lx3-zulu10.1+11-jdk10' from 'https://cache.nixos.org'...
/nix/store/90jrb626qmbf0is642wdc3zfdc625lx3-zulu10.1+11-jdk10

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openjdk10

Partial log (click to expand)

strange: no string table
strange: no string table
strange: no string table
strange: no string table
strange: no string table
strange: no string table
strange: no string table
strange: no string table
strange: no string table
/nix/store/ya6xkhdibdnxhhkij897gyrjqp8s5j43-openjdk-10.0.2-b13

@grahamc
Copy link
Member

grahamc commented Aug 31, 2018

(testing a little thing)

@GrahamcOfBorg build openjdk10

@GrahamcOfBorg
Copy link

Success on x86_64-darwin [(full log)](https://logs.nix.ci/?key=nixos/nixpkgs.45881&attempt_id=f26693ea-5ca7-43c4-83d6-0f8c2cc4082a)

Attempted: openjdk10

Partial log (click to expand)

/nix/store/90jrb626qmbf0is642wdc3zfdc625lx3-zulu10.1+11-jdk10

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented Aug 31, 2018 •
edited by grahamc

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: openjdk10

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: openjdk10

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: openjdk10

Partial log (click to expand)

  inflating: ZuluJCEPolicies/DISCLAIMER
  inflating: ZuluJCEPolicies/local_policy.jar
  inflating: ZuluJCEPolicies/US_export_policy.jar
post-installation fixup
moving /nix/store/yzw373n4qjh475v7gm9c3g452xbhx6ka-zulu10.3+5-jdk10/man to /nix/store/yzw373n4qjh475v7gm9c3g452xbhx6ka-zulu10.3+5-jdk10/share/man
gzipping man pages under /nix/store/yzw373n4qjh475v7gm9c3g452xbhx6ka-zulu10.3+5-jdk10/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/yzw373n4qjh475v7gm9c3g452xbhx6ka-zulu10.3+5-jdk10/lib  /nix/store/yzw373n4qjh475v7gm9c3g452xbhx6ka-zulu10.3+5-jdk10/bin
patching script interpreter paths in /nix/store/yzw373n4qjh475v7gm9c3g452xbhx6ka-zulu10.3+5-jdk10
/nix/store/yzw373n4qjh475v7gm9c3g452xbhx6ka-zulu10.3+5-jdk10

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openjdk10

Partial log (click to expand)

strange: no string table
strange: no string table
strange: no string table
strange: no string table
strange: no string table
strange: no string table
strange: no string table
strange: no string table
strange: no string table
/nix/store/ya6xkhdibdnxhhkij897gyrjqp8s5j43-openjdk-10.0.2-b13

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openjdk10

Partial log (click to expand)

/nix/store/ya6xkhdibdnxhhkij897gyrjqp8s5j43-openjdk-10.0.2-b13

@xeji xeji merged commit 254bb9d into NixOS:master Aug 31, 2018
@andir andir deleted the openjdk10 branch September 1, 2018 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andir @GrahamcOfBorg @grahamc @xeji