Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt-3: Make configureFlags a list #45888

Merged
merged 1 commit into from Sep 1, 2018
Merged

qt-3: Make configureFlags a list #45888

merged 1 commit into from Sep 1, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

This is cleaner, and makes it easier to limit rebuilds while editing the flags.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 mentioned this pull request Aug 31, 2018
Closed
9 tasks
@FRidh
Copy link
Member

FRidh commented Sep 1, 2018

Qt 3.3 is from February 2004. I think it's time we drop it from our repository. I see 2 applications using it, lprof, which should be able to use a newer version, and an old version of taskjuggler.

@FRidh
Copy link
Member

FRidh commented Sep 1, 2018

Regarding lprof. Seems Qt4 support was merged in CVS, but there has not been any release with it.

@Ericson2314
Copy link
Member Author

I think I'll merge this now to help with my proposed configure flags deprecation, but yes I approve of just deleting Qt 3 too.

@Ericson2314 Ericson2314 merged commit 31e6750 into NixOS:master Sep 1, 2018
@Ericson2314 Ericson2314 deleted the qt3-configure-flags branch September 1, 2018 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @FRidh @GrahamcOfBorg