Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phantoms are rendered in wrong horizontal position if draw_centered is true. #2416

Closed
deathaxe opened this issue Sep 10, 2018 · 1 comment
Closed

Phantoms are rendered in wrong horizontal position if draw_centered is true. #2416

deathaxe opened this issue Sep 10, 2018 · 1 comment
Labels
C: Minihtml R: fixed S: minor T: bug
Milestone
Build 3193

Comments

@deathaxe
Copy link
Collaborator

Summary

This issue is a forwarded report of jisaacks/GitGutter#514

Expected behavior

Respect the left offset of the text content when positioning phantoms.

Actual behavior

Phantoms are always placed as the text was aligned left, which causes phantoms to be placed at the wrong position if the setting draw_centered is true.

screenshot

Steps to reproduce

  1. Install any plugin which adds phantoms to the document (e.g. ColorHelper).
  2. Open a CSS file which ColorHelper adds phantoms to.
  3. Switch to distraction free mode.

Environment

  • Operating system and version:
    • Windows 10
  • Monitor:
    • Resolution 1900x1200
    • dpi_scale used in ST 1.0
  • Sublime Text:
    • Build 3176
    • 64 bit
deathaxe added a commit to jisaacks/GitGutter that referenced this issue Sep 10, 2018
@deathaxe
Fix: Disable line annotations in distraction free mode (#514)
5813910 
Fixes #514

Sublime Text 3176 does not place phantoms correctly, if `draw_centered`
setting is set `true`.

The core issue is reported at:

  sublimehq/sublime_text#2416
@wbond
Copy link
Member

wbond commented Mar 1, 2019

This should be resolved in build 3193

@wbond wbond closed this as completed Mar 1, 2019
@wbond wbond added the R: fixed label Mar 1, 2019
@FichteFoll FichteFoll added this to the Build 3193 milestone Mar 1, 2019
@smcenlly smcenlly mentioned this issue Mar 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Minihtml R: fixed S: minor T: bug
Projects
None yet
Milestone
Build 3193
Development

No branches or pull requests
4 participants
@wbond @FichteFoll @keith-hall @deathaxe