networking.hostId: fix cmd in description #46495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikarvstedt
force-pushed
the
hostid-cmd
branch
from
8e842cb
to
f1de24b
Compare
erikarvstedt
force-pushed
the
hostid-cmd
branch
from
f1de24b
to
b0608da
Compare
Mic92
reviewed
Sep 11, 2018
| @@ -341,7 +341,7 @@ in | |||
| You should try to make this ID unique among your machines. You can | |||
| generate a random 32-bit ID using the following commands: | |||
|
|
|||
| <literal>cksum /etc/machine-id | while read c rest; do printf "%x" $c; done</literal> | |||
| <literal>cksum /etc/machine-id | while read c rest; do printf "%08x" $c; done</literal> | |||
There was a problem hiding this comment.
I agree head -c 8 /etc/machine-id makes more sense.
1. Simplify the command by reading directly from /etc/machine-id which is already a random, lower-case hex string 2. Previously, the command output could be too short because of missing leading digits. This is now fixed.
erikarvstedt
force-pushed
the
hostid-cmd
branch
from
b0608da
to
7a42623
Compare
|
I've updated the patch to use |
|
backport: c1713a1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pad the hex literal with leading zeros to the required length of 8 bytes (32 bit).
Question to reviewers:
As
/etc/machine-idis already a random, lower-case hex string, why not just usehead -c 8 /etc/machine-id?