Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.{pydub,readme_renderer,pyfakefs,us,restview}: fix build #46488

Merged
merged 8 commits into from Sep 13, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 10, 2018

Motivation for this change

Fix some random python packages for #45960.

Things done
  • Built on NixOS in a sandbox
  • passes nix-review

Required jellyfish==0.5.6 but we have 0.6.1. Loosen requirements.
Disable one test case that has failed since last bleach update.
Update and disable some failing test cases
- remove obsolete patch that caused build failure
- no tests were run because required data files were missing in pypi
  version; use github version instead
@xeji xeji requested a review from FRidh as a code owner September 10, 2018 16:14
@xeji
Copy link
Contributor Author

xeji commented Sep 10, 2018

@GrahamcOfBorg build python27Packages.readme_renderer python36Packages.readme_renderer

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.readme_renderer, python36Packages.readme_renderer

Partial log (click to expand)

tests/test_txt.py .                                                      [100%]

=================== 60 passed, 1 deselected in 0.95 seconds ====================
tests/test_markdown.py .......................................           [ 75%]
tests/test_rst.py ..............                                         [ 98%]
tests/test_txt.py .                                                      [100%]

=================== 60 passed, 1 deselected in 0.90 seconds ====================
/nix/store/95arps45bmqjzzw752pvgy213h4jzifj-python2.7-readme_renderer-21.0
/nix/store/4mmdxip8s6crsx2r8i1w5dqydcjb2l4k-python3.6-readme_renderer-21.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.readme_renderer, python36Packages.readme_renderer

Partial log (click to expand)

collected 61 items / 1 deselected

tests/test_integration_distutils.py ......                               [ 10%]
tests/test_markdown.py .......................................           [ 75%]
tests/test_rst.py ..............                                         [ 98%]
tests/test_txt.py .                                                      [100%]

=================== 60 passed, 1 deselected in 1.16 seconds ====================
/nix/store/nkvynms59a1dbji4a15vahas6bj5z1pp-python2.7-readme_renderer-21.0
/nix/store/2777ycs1fyi1zp206fgjjc37w7wy4lcm-python3.6-readme_renderer-21.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.readme_renderer, python36Packages.readme_renderer

Partial log (click to expand)

collected 61 items / 1 deselected

tests/test_integration_distutils.py ......                               [ 10%]
tests/test_markdown.py .......................................           [ 75%]
tests/test_rst.py ..............                                         [ 98%]
tests/test_txt.py .                                                      [100%]

=================== 60 passed, 1 deselected in 4.65 seconds ====================
/nix/store/3gwhrb9wyll2sn0wlqdwnlp7lx7ia8y5-python2.7-readme_renderer-21.0
/nix/store/c6ra6l73dy0q0wipim1kzf028xbr699z-python3.6-readme_renderer-21.0

@xeji
Copy link
Contributor Author

xeji commented Sep 10, 2018

@GrahamcOfBorg build python27Packages.pyfakefs python36Packages.pyfakefs

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.pyfakefs, python36Packages.pyfakefs

Partial log (click to expand)

OK (skipped=278, expected failures=1)
============================= test session starts ==============================
platform linux -- Python 3.6.6, pytest-3.7.4, py-1.5.4, pluggy-0.7.1
rootdir: /build/source, inifile:
plugins: pyfakefs-3.4.3
collected 1 item

pyfakefs/tests/pytest_plugin_test.py .                                   [100%]

=========================== 1 passed in 0.04 seconds ===========================

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python27Packages.pyfakefs, python36Packages.pyfakefs

Partial log (click to expand)

+ ['Dest']
?   ^


----------------------------------------------------------------------
Ran 1665 tests in 12.704s

FAILED (failures=1, skipped=231, expected failures=1)
builder for '/nix/store/c5k3vir8wszg2vr5vhc3236qk3q80sxf-python3.6-pyfakefs-3.4.3.drv' failed with exit code 1
error: build of '/nix/store/c5k3vir8wszg2vr5vhc3236qk3q80sxf-python3.6-pyfakefs-3.4.3.drv', '/nix/store/rpqk8bywbgp5lvafqlds6h6hbw2jb01i-python2.7-pyfakefs-3.4.3.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.pyfakefs, python36Packages.pyfakefs

Partial log (click to expand)

OK (skipped=278, expected failures=1)
============================= test session starts ==============================
platform linux -- Python 3.6.6, pytest-3.7.4, py-1.5.4, pluggy-0.7.1
rootdir: /build/source, inifile:
plugins: pyfakefs-3.4.3
collected 1 item

pyfakefs/tests/pytest_plugin_test.py .                                   [100%]

=========================== 1 passed in 0.20 seconds ===========================

@xeji
Copy link
Contributor Author

xeji commented Sep 10, 2018

@GrahamcOfBorg build python27Packages.pydub python36Packages.pydub

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.pydub, python36Packages.pydub

Partial log (click to expand)

Ran 88 tests in 14.819s

OK
...............................................................................................
----------------------------------------------------------------------
Ran 95 tests in 15.930s

OK
/nix/store/dj10c4bjvzizc55nprmcppl37zaczasz-python2.7-pydub-0.22.1
/nix/store/fwc1ji99klh1m9zdnx57yzrg198id5z9-python3.6-pydub-0.22.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.pydub, python36Packages.pydub

Partial log (click to expand)

patching script interpreter paths in /nix/store/r4iv16m1j4s1dmb37z25wlk3blqr948m-python3.6-pydub-0.22.1
checking for references to /build in /nix/store/r4iv16m1j4s1dmb37z25wlk3blqr948m-python3.6-pydub-0.22.1...
running install tests
...............................................................................................
----------------------------------------------------------------------
Ran 95 tests in 20.703s

OK
/nix/store/bpvf94lz034alqxy9cvkskizmjqvsiby-python2.7-pydub-0.22.1
/nix/store/r4iv16m1j4s1dmb37z25wlk3blqr948m-python3.6-pydub-0.22.1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python27Packages.pydub, python36Packages.pydub

Partial log (click to expand)

Ran 88 tests in 109.835s

FAILED (failures=1)
builder for '/nix/store/45zjdddhp4v3a1y3aw03xys6j7za5acj-python2.7-pydub-0.22.1.drv' failed with exit code 1
...............................................................................................
----------------------------------------------------------------------
Ran 95 tests in 125.035s

OK
error: build of '/nix/store/45zjdddhp4v3a1y3aw03xys6j7za5acj-python2.7-pydub-0.22.1.drv' failed

@xeji
Copy link
Contributor Author

xeji commented Sep 10, 2018

@GrahamcOfBorg build python27Packages.us python36Packages.us

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.us, python36Packages.us

Partial log (click to expand)

/build/us-1.0.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5d4i5f9w0car02yhizfh841rczigbrsr-python3.6-us-1.0.0
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5d4i5f9w0car02yhizfh841rczigbrsr-python3.6-us-1.0.0/lib  /nix/store/5d4i5f9w0car02yhizfh841rczigbrsr-python3.6-us-1.0.0/bin
patching script interpreter paths in /nix/store/5d4i5f9w0car02yhizfh841rczigbrsr-python3.6-us-1.0.0
checking for references to /build in /nix/store/5d4i5f9w0car02yhizfh841rczigbrsr-python3.6-us-1.0.0...
wrapping `/nix/store/5d4i5f9w0car02yhizfh841rczigbrsr-python3.6-us-1.0.0/bin/states'...
/nix/store/ayvllmv4icqn7a7k49a0dmf9ivffw4n3-python2.7-us-1.0.0
/nix/store/5d4i5f9w0car02yhizfh841rczigbrsr-python3.6-us-1.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.us, python36Packages.us

Partial log (click to expand)

Successfully installed us-1.0.0
wrapping `/nix/store/xhbc1jkgj9gmd9byvk3inpw4pgscffhb-python2.7-us-1.0.0/bin/states'...
/private/tmp/nix-build-python3.6-us-1.0.0.drv-0/us-1.0.0
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/mwlzb6g05k3ai8bs4v2abh7fz3whzzma-python3.6-us-1.0.0/lib  /nix/store/mwlzb6g05k3ai8bs4v2abh7fz3whzzma-python3.6-us-1.0.0/bin
patching script interpreter paths in /nix/store/mwlzb6g05k3ai8bs4v2abh7fz3whzzma-python3.6-us-1.0.0
wrapping `/nix/store/mwlzb6g05k3ai8bs4v2abh7fz3whzzma-python3.6-us-1.0.0/bin/states'...
/nix/store/xhbc1jkgj9gmd9byvk3inpw4pgscffhb-python2.7-us-1.0.0
/nix/store/mwlzb6g05k3ai8bs4v2abh7fz3whzzma-python3.6-us-1.0.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.us, python36Packages.us

Partial log (click to expand)

/build/us-1.0.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qv8nx61nrlpg6x1mgl4rfgh4dxbpy7q5-python3.6-us-1.0.0
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qv8nx61nrlpg6x1mgl4rfgh4dxbpy7q5-python3.6-us-1.0.0/lib  /nix/store/qv8nx61nrlpg6x1mgl4rfgh4dxbpy7q5-python3.6-us-1.0.0/bin
patching script interpreter paths in /nix/store/qv8nx61nrlpg6x1mgl4rfgh4dxbpy7q5-python3.6-us-1.0.0
checking for references to /build in /nix/store/qv8nx61nrlpg6x1mgl4rfgh4dxbpy7q5-python3.6-us-1.0.0...
wrapping `/nix/store/qv8nx61nrlpg6x1mgl4rfgh4dxbpy7q5-python3.6-us-1.0.0/bin/states'...
/nix/store/hacf2r6d7gn4yh17csf51y6k1dldwra0-python2.7-us-1.0.0
/nix/store/qv8nx61nrlpg6x1mgl4rfgh4dxbpy7q5-python3.6-us-1.0.0

one test failed due to rounding errors, disable it
One test failed on darwin due to case-insensitive file system,
disable it.
@xeji
Copy link
Contributor Author

xeji commented Sep 10, 2018

@GrahamcOfBorg build python27Packages.pyfakefs python36Packages.pyfakefs

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.pyfakefs, python36Packages.pyfakefs

Partial log (click to expand)

/nix/store/hnj4jcrhkrabz5g9njnsz6s6l9fsbgp0-python2.7-pyfakefs-3.4.3
/nix/store/x6hs2ch6qmj5hx310131d7fsaqb3sd3n-python3.6-pyfakefs-3.4.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.pyfakefs, python36Packages.pyfakefs

Partial log (click to expand)

/nix/store/gfhbq494g5jpk3yjvkl2v4wr2zxq6r5q-python2.7-pyfakefs-3.4.3
/nix/store/a0h7xn7i91kpg5d4pj6wxzxi3gamh71k-python3.6-pyfakefs-3.4.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.pyfakefs, python36Packages.pyfakefs

Partial log (click to expand)

OK (skipped=231, expected failures=1)
============================= test session starts ==============================
platform darwin -- Python 3.6.6, pytest-3.7.4, py-1.5.4, pluggy-0.7.1
rootdir: /private/tmp/nix-build-python3.6-pyfakefs-3.4.3.drv-0/source, inifile:
plugins: pyfakefs-3.4.3
collected 1 item

pyfakefs/tests/pytest_plugin_test.py .                                   [100%]

=========================== 1 passed in 0.06 seconds ===========================

@xeji
Copy link
Contributor Author

xeji commented Sep 10, 2018

@GrahamcOfBorg build python27Packages.pydub python36Packages.pydub

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.pydub, python36Packages.pydub

Partial log (click to expand)

Ran 88 tests in 14.927s

OK
...............................................................................................
----------------------------------------------------------------------
Ran 95 tests in 15.912s

OK
/nix/store/qmd14sfwani1k7d7qx2niqml2ckwxfcc-python2.7-pydub-0.22.1
/nix/store/dm2mpacrp8wjyng04ikv259nk4254rm4-python3.6-pydub-0.22.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.pydub, python36Packages.pydub

Partial log (click to expand)

patching script interpreter paths in /nix/store/jaaijnjcwkxvgjg8c8ljf0hd1jqdmxab-python3.6-pydub-0.22.1
checking for references to /build in /nix/store/jaaijnjcwkxvgjg8c8ljf0hd1jqdmxab-python3.6-pydub-0.22.1...
running install tests
...............................................................................................
----------------------------------------------------------------------
Ran 95 tests in 20.676s

OK
/nix/store/nm5hszg4qnl49c35kwsiij4isv5v20q6-python2.7-pydub-0.22.1
/nix/store/jaaijnjcwkxvgjg8c8ljf0hd1jqdmxab-python3.6-pydub-0.22.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.pydub, python36Packages.pydub

Partial log (click to expand)

Ran 87 tests in 109.680s

OK
..............................................................................................
----------------------------------------------------------------------
Ran 94 tests in 124.977s

OK
/nix/store/s9df6ls41kjivg70y8vfb8nbvb897iz1-python2.7-pydub-0.22.1
/nix/store/8ximl9x23vf7smj6rs6nwhkvxhfh5bhc-python3.6-pydub-0.22.1

Failed after readme_renderer was updated. Apply an upstream patch.
@xeji xeji changed the title pythonPackages.{pydub,readme_renderer,pyfakefs,us}: fix build pythonPackages.{pydub,readme_renderer,pyfakefs,us,restview}: fix build Sep 13, 2018
@xeji
Copy link
Contributor Author

xeji commented Sep 13, 2018

@GrahamcOfBorg build python27Packages.restview python36Packages.restview

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.restview, python36Packages.restview

Partial log (click to expand)

Doctest: restview.restviewhttp.SyntaxHighlightingHTMLTranslator.link_local_files ... ok
parse_address (restview.restviewhttp)
Doctest: restview.restviewhttp.parse_address ... ok

----------------------------------------------------------------------
Ran 74 tests in 0.207s

OK
/nix/store/0qmiar8640b3ri7x4483hkimkn4fzvi9-python2.7-restview-2.9.1
/nix/store/3s9n90zbvlrqff4x0f84s02r10kl7n85-python3.6-restview-2.9.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.restview, python36Packages.restview

Partial log (click to expand)

Doctest: restview.restviewhttp.SyntaxHighlightingHTMLTranslator.link_local_files ... ok
parse_address (restview.restviewhttp)
Doctest: restview.restviewhttp.parse_address ... ok

----------------------------------------------------------------------
Ran 74 tests in 0.458s

OK
/nix/store/zw129pjs2dk2n02kc4salx6lfbrrzp2m-python2.7-restview-2.9.1
/nix/store/vvzqhjiy9zkjjzyxwhp3wvj1vjrwczig-python3.6-restview-2.9.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.restview, python36Packages.restview

Partial log (click to expand)

Doctest: restview.restviewhttp.SyntaxHighlightingHTMLTranslator.link_local_files ... ok
parse_address (restview.restviewhttp)
Doctest: restview.restviewhttp.parse_address ... ok

----------------------------------------------------------------------
Ran 74 tests in 0.945s

OK
/nix/store/9rwp7baci8vi57xk6m0dkp66007502dd-python2.7-restview-2.9.1
/nix/store/1cmwav3r809a0l3kq12c8facl2a4pyka-python3.6-restview-2.9.1

@xeji xeji merged commit 2bc08ce into NixOS:master Sep 13, 2018
@xeji xeji deleted the p/python-fixes branch September 13, 2018 09:41
@xeji
Copy link
Contributor Author

xeji commented Sep 13, 2018

backported: cedae2b..ae181c3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants