Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxqt: move contents of base, core and optional to parent directory #46484

Merged
merged 1 commit into from Sep 10, 2018
Merged

lxqt: move contents of base, core and optional to parent directory #46484

merged 1 commit into from Sep 10, 2018

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Sep 10, 2018

Motivation for this change

Move the contents of the base, core and optional subdirectories of pkgs/desktops/lxqt/ to the parent directory. There are not that many packages for LXQt and keeping them together would be easier to work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Sep 10, 2018

@GrahamcOfBorg eval

@xeji xeji merged commit 2047e28 into NixOS:master Sep 10, 2018
xeji pushed a commit that referenced this pull request Sep 10, 2018
)

(cherry picked from commit 2047e28)

a noop change, backported for easier maintenance
@xeji
Copy link
Contributor

xeji commented Sep 10, 2018

backported to 18.09 in f02eb7d for easier maintenance, it's a noop change anyway.

@romildo romildo deleted the upd.lxqt branch September 11, 2018 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants