Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kde-frameworks: 5.49 -> 5.50 #46483

Merged
merged 2 commits into from Sep 13, 2018
Merged

kde-frameworks: 5.49 -> 5.50 #46483

merged 2 commits into from Sep 13, 2018

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Sep 10, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bkchr bkchr requested a review from ttuegel as a code owner September 10, 2018 14:20
@ttuegel
Copy link
Member

ttuegel commented Sep 11, 2018

Could you add an expression for the new Framework, syndication?

@bkchr
Copy link
Contributor Author

bkchr commented Sep 11, 2018

Yep. Will do that.

@bkchr
Copy link
Contributor Author

bkchr commented Sep 13, 2018

@ttuegel done :)

ttuegel
ttuegel approved these changes Sep 13, 2018
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ttuegel ttuegel merged commit 5039621 into NixOS:master Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkchr @ttuegel @GrahamcOfBorg