Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos: sound: warn about changes to defaults (18.03) #46491

Closed
wants to merge 2 commits into from

Conversation

oxij
Copy link
Member

@oxij oxij commented Sep 10, 2018

Backport of #46490 to 18.03.

Yeah, it's ugly. But it's the minimal change that doesn't break anything
else.

(cherry picked from commit 4017fdc)
I still think that change needs to be reverted, but if there's no will
for that let's at the very least warn users about the problem that change
introduced. Without this most ALSA users switching from releases
before 18.03 will get sound, but won't get ALSA state save/restore.
That would be very confusing.

All modules and tests that want to be completely headless disable this
option explicitly. I.e. you won't see this warning unless you are
affected.

(cherry picked from commit 26934c3)
@infinisil
Copy link
Member

Not doing backports to 18.03 anymore

@infinisil infinisil closed this Nov 17, 2018
@oxij oxij deleted the nixos/alsa-default-18.03 branch November 18, 2018 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants