Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.ppx_import: 1.4 -> 1.5 #46489

Merged
merged 1 commit into from Sep 18, 2018
Merged

ocamlPackages.ppx_import: 1.4 -> 1.5 #46489

merged 1 commit into from Sep 18, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 10, 2018

Motivation for this change

Compatibility with OCaml 4.07.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Sep 11, 2018

@GrahamcOfBorg build fstar pyre

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: fstar

The following builds were skipped because they don't evaluate on x86_64-darwin: pyre

Partial log (click to expand)

cd ../../examples && find . -type f -exec install -m 644 -D {} /nix/store/b2c1jcp7asvpprixdpc29fi09kiifsym-fstar-0.9.6.0/share/fstar/examples/{} \;
cd ../../ucontrib && find . -type f -exec install -m 644 -D {} /nix/store/b2c1jcp7asvpprixdpc29fi09kiifsym-fstar-0.9.6.0/share/fstar/contrib/{} \;
# Then the tutorial
cd ../../doc/tutorial && find . -type f -exec install -m 644 -D {} /nix/store/b2c1jcp7asvpprixdpc29fi09kiifsym-fstar-0.9.6.0/share/fstar/tutorial/{} \;
make: Leaving directory '/private/tmp/nix-build-fstar-0.9.6.0.drv-0/source/src/ocaml-output'
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/b2c1jcp7asvpprixdpc29fi09kiifsym-fstar-0.9.6.0/lib  /nix/store/b2c1jcp7asvpprixdpc29fi09kiifsym-fstar-0.9.6.0/bin
patching script interpreter paths in /nix/store/b2c1jcp7asvpprixdpc29fi09kiifsym-fstar-0.9.6.0
/nix/store/b2c1jcp7asvpprixdpc29fi09kiifsym-fstar-0.9.6.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: fstar, pyre

Partial log (click to expand)

Failure: >>src/batBool.ml:113

src/batBool.ml:113:  of_float (1. /. 0.) = false
///////////////////////////////////////////////////////////////////////////////
Ran: 1725 tests in: 35.85 seconds.
FAILURE
make: *** [Makefile:217: qtest-byte] Error 1
builder for '/nix/store/p7aa30i52ikrv9whm3yrwdvi8h2ga1wn-ocaml4.06.1-batteries-2.8.0.drv' failed with exit code 2
cannot build derivation '/nix/store/yxskwmifv8s43w30zls4l7kdhihg8dr2-fstar-0.9.6.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/dp6csyzz95hqp4vca8ia9l9jxhwqqlwq-pyre-check-0.0.11.drv', '/nix/store/yxskwmifv8s43w30zls4l7kdhihg8dr2-fstar-0.9.6.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fstar, pyre

Partial log (click to expand)

Successfully installed pyre-check-0.0.11
/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fq0y285gm5xfidp57br634bliw8r6kf8-pyre-check-0.0.11
shrinking /nix/store/fq0y285gm5xfidp57br634bliw8r6kf8-pyre-check-0.0.11/bin/pyre.bin
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fq0y285gm5xfidp57br634bliw8r6kf8-pyre-check-0.0.11/lib  /nix/store/fq0y285gm5xfidp57br634bliw8r6kf8-pyre-check-0.0.11/bin
patching script interpreter paths in /nix/store/fq0y285gm5xfidp57br634bliw8r6kf8-pyre-check-0.0.11
checking for references to /build in /nix/store/fq0y285gm5xfidp57br634bliw8r6kf8-pyre-check-0.0.11...
wrapping `/nix/store/fq0y285gm5xfidp57br634bliw8r6kf8-pyre-check-0.0.11/bin/pyre'...

@vbgl vbgl merged commit 66842c9 into NixOS:master Sep 18, 2018
@vbgl vbgl deleted the ocaml-ppx_import-1.5 branch September 18, 2018 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @GrahamcOfBorg