Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

govendor: init at 1.0.9 #46485

Merged
merged 1 commit into from Sep 10, 2018
Merged

govendor: init at 1.0.9 #46485

merged 1 commit into from Sep 10, 2018

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Sep 10, 2018 •
edited

Motivation for this change

needed govendor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: govendor

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/83j0sy5p2akmj7hs70db5yqpwsvhmcrz-govendor-1.0.9-bin
shrinking /nix/store/83j0sy5p2akmj7hs70db5yqpwsvhmcrz-govendor-1.0.9-bin/bin/govendor
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/83j0sy5p2akmj7hs70db5yqpwsvhmcrz-govendor-1.0.9-bin/bin
patching script interpreter paths in /nix/store/83j0sy5p2akmj7hs70db5yqpwsvhmcrz-govendor-1.0.9-bin
checking for references to /build in /nix/store/83j0sy5p2akmj7hs70db5yqpwsvhmcrz-govendor-1.0.9-bin...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/83j0sy5p2akmj7hs70db5yqpwsvhmcrz-govendor-1.0.9-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: govendor

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3zwhn8c15h9v35afgbi8f2fizya2a00z-govendor-1.0.9-bin
shrinking /nix/store/3zwhn8c15h9v35afgbi8f2fizya2a00z-govendor-1.0.9-bin/bin/govendor
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3zwhn8c15h9v35afgbi8f2fizya2a00z-govendor-1.0.9-bin/bin
patching script interpreter paths in /nix/store/3zwhn8c15h9v35afgbi8f2fizya2a00z-govendor-1.0.9-bin
checking for references to /build in /nix/store/3zwhn8c15h9v35afgbi8f2fizya2a00z-govendor-1.0.9-bin...
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
/nix/store/3zwhn8c15h9v35afgbi8f2fizya2a00z-govendor-1.0.9-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: govendor

Partial log (click to expand)

find: '/nix/store/prwfpp7rvmg4kvv018pfjm8fg8iccnqc-govendor-1.0.9': No such file or directory
find: '/nix/store/prwfpp7rvmg4kvv018pfjm8fg8iccnqc-govendor-1.0.9': No such file or directory
find: '/nix/store/prwfpp7rvmg4kvv018pfjm8fg8iccnqc-govendor-1.0.9': No such file or directory
find: '/nix/store/prwfpp7rvmg4kvv018pfjm8fg8iccnqc-govendor-1.0.9': No such file or directory
find: '/nix/store/prwfpp7rvmg4kvv018pfjm8fg8iccnqc-govendor-1.0.9': No such file or directory
find: '/nix/store/prwfpp7rvmg4kvv018pfjm8fg8iccnqc-govendor-1.0.9': No such file or directory
find: '/nix/store/prwfpp7rvmg4kvv018pfjm8fg8iccnqc-govendor-1.0.9': No such file or directory
find: '/nix/store/prwfpp7rvmg4kvv018pfjm8fg8iccnqc-govendor-1.0.9': No such file or directory
find: '/nix/store/prwfpp7rvmg4kvv018pfjm8fg8iccnqc-govendor-1.0.9': No such file or directory
/nix/store/rwj8m5aya60jy3cv7w98kn23mln6n525-govendor-1.0.9-bin

adisbladis
adisbladis reviewed Sep 10, 2018
View reviewed changes
pkgs/development/tools/govendor/default.nix Outdated
};

meta = with stdenv.lib; {
homepage = https://github.com/golang/dep;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

homepage attribute looks wrong

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, nice catch

@zimbatm zimbatm merged commit 404b224 into NixOS:master Sep 10, 2018
@zimbatm zimbatm deleted the govendor-1.0.9 branch September 10, 2018 16:48
zimbatm added a commit that referenced this pull request Sep 10, 2018
@zimbatm
govendor: init at 1.0.9 (#46485)
57268a9 
(cherry picked from commit 404b224)
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: govendor

Partial log (click to expand)

/nix/store/83j0sy5p2akmj7hs70db5yqpwsvhmcrz-govendor-1.0.9-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: govendor

Partial log (click to expand)

/nix/store/rwj8m5aya60jy3cv7w98kn23mln6n525-govendor-1.0.9-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: govendor

Partial log (click to expand)

/nix/store/3zwhn8c15h9v35afgbi8f2fizya2a00z-govendor-1.0.9-bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimbatm @GrahamcOfBorg @adisbladis