vimPlugins: Fix update.py, add/update plugins #46496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Sep 10, 2018
| @@ -292,7 +292,7 @@ def generate_nix(plugins: List[Tuple[str, Plugin]]): | |||
| name = "{plugin.normalized_name}-{plugin.version}"; | |||
| src = fetchFromGitHub {{ | |||
| owner = "{owner}"; | |||
| repo = "{plugin.name}"; | |||
| repo = "{repo}"; | |||
There was a problem hiding this comment.
oh, snap. I wonder why I was able to build all plugins. I blame fixed-input derivations for that.
Mic92
reviewed
Sep 11, 2018
| @@ -2,16 +2,6 @@ | |||
| { buildVimPluginFrom2Nix, fetchFromGitHub }: | |||
|
|
|||
| { | |||
| a-vim = buildVimPluginFrom2Nix { | |||
Mic92
reviewed
Sep 11, 2018
| @@ -182,8 +182,8 @@ | |||
| }; | |||
| }; | |||
|
|
|||
| Colour-Sampler-Pack = buildVimPluginFrom2Nix { | |||
| name = "Colour-Sampler-Pack-2012-11-30"; | |||
| colorsamplerpack = buildVimPluginFrom2Nix { | |||
|
I would prefer if we do not manually have to change stuff in this file. |
|
After running the |
|
Ah it get its name by a reverse lookup from the aliases. |
|
This pull request fixes that: #46561 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The
update.pyscript in latestmasterwas generating wronggenerated.nix- therepoattr would have.replaced by-.(becauseplugin.namecontains the name with.replaced by-). Refs #46394Note, that
easymotionvim plugin has been moved to easymotion/easymotioncc @Mic92
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)