applying various patches and fixing various things #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleverca22
force-pushed
the
fixing-everything
branch
from
f0c0e16
to
1317417
Compare
this fixes the ability to prefetch things with submodules
cleverca22
changed the title
cleverca22
force-pushed
the
fixing-everything
branch
2 times, most recently
from
d0380cb
to
a4469f8
Compare
cleverca22
force-pushed
the
fixing-everything
branch
from
a4469f8
to
7568b89
Compare
|
Maybe you could make this a few PRs:
for the one about notify events, could you write a bit more about the why's? |
grahamc
reviewed
Mar 18, 2019
|
|
||
| pqxx::result res = txn.parameterized | ||
| ("select id, project, jobset, job, drvPath, maxsilent, timeout, timestamp, globalPriority, priority from Builds " | ||
| "where id IN (select build from jobsetevalmembers where eval = $1) order by globalPriority desc, id") |
There was a problem hiding this comment.
This looks like it could be a fairly simple join, and avoid a temporary table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copied from NixOS/nixpkgs@c501958 and NixOS/nixpkgs@f7fe612
nix-prefetch-gitto accept submodules on build inputs-pr-123on the jobset namehydra-eval-jobsetandhydra-queue-runnerit now sends an eval#, rather then the lowest build#, and then queue-runner just looks up the members of the eval