Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ammonite: 1.1.2 -> 1.2.0 #46492

Merged
merged 1 commit into from Sep 11, 2018
Merged

ammonite: 1.1.2 -> 1.2.0 #46492

merged 1 commit into from Sep 11, 2018

Conversation

oscarvarto
Copy link
Contributor

@oscarvarto oscarvarto commented Sep 10, 2018 •
edited

Motivation for this change

Bumping ammonite version to 1.2.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -A ammonite, then executing amm
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

First PR to nixpkgs. I still don't know how to follow lots of the above checks. Will follow instructions if necessary.

@srhb
Copy link
Contributor

srhb commented Sep 11, 2018

@GrahamcOfBorg build ammonite

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: ammonite

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ammonite

Partial log (click to expand)

100   600    0   600    0     0   5128      0 --:--:-- --:--:-- --:--:--  5128
100 26.4M  100 26.4M    0     0  26.9M      0 --:--:-- --:--:-- --:--:-- 46.7M
copying path '/nix/store/4rv37m88jmjiqpr9d4r2s0r2c4cxmcpm-spidermonkey-52.9.0' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/6i2l9mbszlds0p36wgips3d0p6rmnwb6-polkit-0.115' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/488aya5f34bry24dx185k595ygrxbdnb-gconf-3.2.6' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/sw6l31gjkw31kc2gqc49dn98hzdiqmci-gnome-vfs-2.24.4' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/91wwfym087fcrg2iscd5bz3qq1zgz1k8-openjdk-8u181b13-jre' from 'https://nix-cache.s3.amazonaws.com'...
building '/nix/store/l40akndyk9w4qfcbmshl38zmdhpqqslv-ammonite-1.2.0.drv'...
installing
/nix/store/18m2nzhqpayr6ywanw0k3mgdanyvd260-ammonite-1.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ammonite

Partial log (click to expand)

building '/nix/store/5b34my87208qxkf72ls54ar5xpf9p78y-2.12-1.2.0.drv'...

trying https://github.com/lihaoyi/Ammonite/releases/download/1.2.0/2.12-1.2.0
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   600    0   600    0     0   3797      0 --:--:-- --:--:-- --:--:--  3797
100 26.4M  100 26.4M    0     0  7672k      0  0:00:03  0:00:03 --:--:-- 9287k
building '/nix/store/gykdadzl8hx4schxysixszmshacwgkg7-ammonite-1.2.0.drv'...
installing
/nix/store/vvwcccfdq5h238wnm4d08kbm7l8k059y-ammonite-1.2.0

@srhb
Copy link
Contributor

srhb commented Sep 11, 2018

Thanks!

@srhb srhb merged commit 969ca5a into NixOS:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oscarvarto @srhb @GrahamcOfBorg @Janik-Haag