Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Antimony #46486

Merged
merged 1 commit into from Sep 10, 2018
Merged

Fix Antimony #46486

merged 1 commit into from Sep 10, 2018

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Sep 10, 2018

Motivation for this change

Fix for #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested the program
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Sep 10, 2018

@GrahamcOfBorg build antimony

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: antimony

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: antimony

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17
shrinking /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17/bin/antimony
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17/bin
patching script interpreter paths in /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17
checking for references to /build in /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17...
postPatchMkspecs
/nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: antimony

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2pi46k637avr5cq2lckmf9lbz8pnvlx9-antimony-2018-07-17
shrinking /nix/store/2pi46k637avr5cq2lckmf9lbz8pnvlx9-antimony-2018-07-17/bin/antimony
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2pi46k637avr5cq2lckmf9lbz8pnvlx9-antimony-2018-07-17/bin
patching script interpreter paths in /nix/store/2pi46k637avr5cq2lckmf9lbz8pnvlx9-antimony-2018-07-17
checking for references to /build in /nix/store/2pi46k637avr5cq2lckmf9lbz8pnvlx9-antimony-2018-07-17...
postPatchMkspecs
/nix/store/2pi46k637avr5cq2lckmf9lbz8pnvlx9-antimony-2018-07-17

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: antimony

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: antimony

Partial log (click to expand)

/nix/store/2pi46k637avr5cq2lckmf9lbz8pnvlx9-antimony-2018-07-17

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: antimony

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17
shrinking /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17/bin/antimony
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17/bin
patching script interpreter paths in /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17
checking for references to /build in /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17...
postPatchMkspecs
/nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17

Mic92
Mic92 reviewed Sep 10, 2018
View reviewed changes
pkgs/applications/graphics/antimony/default.nix
gitRev = "020910c25614a3752383511ede5a1f5551a8bd39";
gitBranch = "master";
gitRev = "60a58688e552f12501980c4bdab034ab0f2ba059";
gitBranch = "develop";
gitTag = "0.9.3";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitTag can be removed for the time being.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still used in line 39, I think it's used by the program to display the current version.

@xeji xeji merged commit fd7e69b into NixOS:master Sep 10, 2018
xeji pushed a commit that referenced this pull request Sep 10, 2018
@rnhmjoj @xeji
antimony: 0.9.3 -> 2018-10-17 (#46486)
d164d7e 
(cherry picked from commit fd7e69b)
@xeji
Copy link
Contributor

xeji commented Sep 10, 2018

backported: d164d7e

@bendlas bendlas mentioned this pull request Oct 31, 2018
Closed
@rnhmjoj rnhmjoj deleted the sb branch February 22, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rnhmjoj @Mic92 @GrahamcOfBorg @xeji