nixos: sound: warn about changes to defaults #46490
Conversation
I still think that change needs to be reverted, but if there's no will for that let's at the very least warn users about the problem that change introduced. Without this most ALSA users switching from releases before 18.03 will get sound, but won't get ALSA state save/restore. That would be very confusing. All modules and tests that want to be completely headless disable this option explicitly. I.e. you won't see this warning unless you are affected.
oxij
force-pushed
the
nixos/alsa-default
branch
from
d8791ba
to
26934c3
Compare
|
Edit: turns out the brokenness was already included into 18.03 =/ Should I make a PR for 18.03 too? |
|
And then I did: #46491. |
| warnings = optional (options.sound.enable.highestPrio > 1000) '' | ||
| You don't have `sound.enable` explicitly enabled of disabled. It was | ||
| enabled by default before a43e33d0e48b2284ac3a2222d7f1965cef66f5e2 and | ||
| became disabled by default after e349ccc77febd45abbd14be14f7de123ec4a4da2. |
There was a problem hiding this comment.
There is no point in including commit hashes in warnings.
There was a problem hiding this comment.
I'm open to better suggestions. I don't like being vague like "some commit before 18.03" (which was another option I could come up with) when I can just give the hash (I like doing git show on random hashes I see mentioned in random PRs and comments), but I won't argue against writing whatever else you want if that gets the message across.
|
ping? |
|
Any updates on this pull request, please? |
|
Thank you for your contributions.
|
stale
bot
added
the
2.status: stale
|
It looks like this was relevant to 18.03 / 18.09, which was a long time ago. Feel free to re-open if still relevant. |
Motivation for this change
I still think that change needs to be reverted, but if there's no will for that let's at the very least warn users about the problem that change introduced. Without this most ALSA users switching from releases before 18.03 will get sound, but won't get ALSA state save/restore. That would be very confusing.
All modules and tests that want to be completely headless disable this option explicitly. I.e. you won't see this warning unless you are affected.
Things done
Please backport to 18.09.