Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin: macOS 10.14 compatibility #45437

Merged
merged 3 commits into from Aug 23, 2018
Merged

darwin: macOS 10.14 compatibility #45437

merged 3 commits into from Aug 23, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Aug 21, 2018 •
edited

Motivation for this change

Backport of #43140

Things done
  • Tested without Xcode
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added the 8.has: port to stable A PR already has a backport to the stable release. label Aug 21, 2018
@LnL7
Copy link
Member Author

LnL7 commented Aug 23, 2018

@vcunat Should I send this to staging-18.03?

@vcunat
Copy link
Member

vcunat commented Aug 23, 2018

Yes, I think so.

@LnL7 LnL7 changed the base branch from release-18.03 to staging-18.03 August 23, 2018 21:48
@LnL7 LnL7 merged commit f176956 into NixOS:staging-18.03 Aug 23, 2018
@LnL7 LnL7 deleted the macos-10.14-backport branch August 23, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: stdenv Standard environment 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @vcunat @GrahamcOfBorg