fetchGit: Remove unneeded call to git #2366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikarvstedt
force-pushed
the
faster-fetchgit
branch
from
147e786
to
cfd25ba
Compare
Previously, 'git cat-file -e REV' was always called, even if the rev was already present in the nix store.
erikarvstedt
force-pushed
the
faster-fetchgit
branch
from
cfd25ba
to
466adfc
Compare
|
This sounds related to my problem: #2348 |
|
Your issue has a different scope, but it's still very relevant. |
|
review? |
shlevy
approved these changes
Nov 2, 2018
|
I marked this as stale due to inactivity. → More info |
|
The current version of the git fetcher ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, I wrote this to fix a nix performance issue, which turned out to have other causes specific to my setup.
This patch might still be useful as it saves a needless call to git in the common case where a rev is given that is already in
/nix/store.In this case, now only
~/.cache/nix/gitand/nix/storeare queried and no subprocesses are started.