Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

astrolabe-generator: init at 3.3 #45429

Merged
merged 1 commit into from Aug 23, 2018
Merged

astrolabe-generator: init at 3.3 #45429

merged 1 commit into from Aug 23, 2018

Conversation

bignaux
Copy link
Contributor

@bignaux bignaux commented Aug 21, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

xeji
xeji reviewed Aug 22, 2018
View reviewed changes
pkgs/applications/science/astronomy/astrolabe-generator/default.nix Outdated
version = "3.3";

src = fetchurl {
url = "https://github.com/wymarc/astrolabe-generator/releases/download/v3.3/AstrolabeGenerator-3.3.zip";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you use ${version} instead of 3.3 here it will be easier to upgrade in the future.

pkgs/applications/science/astronomy/astrolabe-generator/default.nix Outdated
homepage = http://www.astrolabeproject.com;
description = "A Java-based tool for generating EPS files for constructing astrolabes and related tools";
license = stdenv.lib.licenses.gpl3;
maintainers = [ stdenv.lib.maintainers.genesis ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add meta.platforms.

pkgs/applications/science/astronomy/astrolabe-generator/default.nix Outdated
sha256 = "141gfmrqa1mf2qas87qig4phym9fg9gbrcfl2idzd5gi91824dn9";
};

buildInputs = [ jre makeWrapper unzip ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unzip and makeWrapper should be nativeBuildInputs as they are only run during the build process.

@xeji
Copy link
Contributor

xeji commented Aug 23, 2018

@GrahamcOfBorg build astrolabe-generator

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: astrolabe-generator

Partial log (click to expand)

building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8pv5anzv3p8rc29g2zssml6jxpika0s4-astrolabe-generator-3.3
/nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip is /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip
stripping (with command /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip and flags -S) in /nix/store/8pv5anzv3p8rc29g2zssml6jxpika0s4-astrolabe-generator-3.3/bin
patching script interpreter paths in /nix/store/8pv5anzv3p8rc29g2zssml6jxpika0s4-astrolabe-generator-3.3
checking for references to /build in /nix/store/8pv5anzv3p8rc29g2zssml6jxpika0s4-astrolabe-generator-3.3...
/nix/store/8pv5anzv3p8rc29g2zssml6jxpika0s4-astrolabe-generator-3.3

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: astrolabe-generator

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: astrolabe-generator

Partial log (click to expand)

configuring
no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
/nix/store/5im29qx9rni3w8l3j8i2yr22sin55kxv-cctools-binutils-darwin/bin/strip is /nix/store/5im29qx9rni3w8l3j8i2yr22sin55kxv-cctools-binutils-darwin/bin/strip
stripping (with command /nix/store/5im29qx9rni3w8l3j8i2yr22sin55kxv-cctools-binutils-darwin/bin/strip and flags -S) in /nix/store/cia3w0adhq6pw8zpndv7avr3r5nyk515-astrolabe-generator-3.3/bin
patching script interpreter paths in /nix/store/cia3w0adhq6pw8zpndv7avr3r5nyk515-astrolabe-generator-3.3
/nix/store/cia3w0adhq6pw8zpndv7avr3r5nyk515-astrolabe-generator-3.3

@xeji xeji merged commit 70d5f16 into NixOS:master Aug 23, 2018
@bignaux bignaux deleted the astrolab branch August 24, 2018 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bignaux @xeji @GrahamcOfBorg