Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd: ensure fsck Requires/After links are created in mount units #45451

Merged
merged 1 commit into from Aug 28, 2018
Merged

systemd: ensure fsck Requires/After links are created in mount units #45451

merged 1 commit into from Aug 28, 2018

Conversation

jerith666
Copy link
Contributor

systemd-fsck-generator only produces these lines if it can find the
necessary fsck executable in its PATH.

fixes #29139.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jerith666
systemd: ensure fsck Requires/After links are created in mount units
13a8df7 
systemd-fsck-generator only produces these lines if it can find the
necessary fsck executable in its PATH.

fixes NixOS#29139.
@Mic92
Copy link
Member

Mic92 commented Aug 23, 2018

@GrahamcOfBorg test fsck

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.fsck

Partial log (click to expand)

syncing
machine: running command: sync
machine: exit status 0
2 out of 2 tests succeeded
test script finished in 21.02s
cleaning up
killing machine (pid 609)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/1x3hifgg3cl0412sfkjz1ssd3przsh17-vm-test-run-fsck

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.fsck

Partial log (click to expand)

syncing
machine: running command: sync
machine: exit status 0
2 out of 2 tests succeeded
test script finished in 21.14s
cleaning up
killing machine (pid 643)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/yyx9pjk3al1wfb2jia1jdi4wcp6njja1-vm-test-run-fsck

@globin globin merged commit 94a906b into NixOS:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fsck is not run automatically for non-root filesystems
4 participants
@jerith666 @Mic92 @GrahamcOfBorg @globin