Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "libvirt: 4.5.0 -> 4.6.0" and attempted fixes #45440

Merged
merged 4 commits into from
Aug 21, 2018
Merged

Revert "libvirt: 4.5.0 -> 4.6.0" and attempted fixes #45440

merged 4 commits into from
Aug 21, 2018
+10 −12

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Aug 21, 2018

Motivation for this change

Libvirt 4.6.0 is broken (runtime errors). The cause seems to be a migration from yajl to jansson for JSON support. Upstream has reverted this after 4.6.0. Instead of applying a large number of patches,
let's revert to libvirt 4.5.0 (which worked fine) and wait for the next upstream release.

This reverts the version bump and some unsuccessful attempts to fix it.

See also discussion in #45409 .

Things done

Built on NixOS.

cc @volth @LnL7 @fpletz @pikajude @VShell

xeji added 3 commits August 21, 2018 22:03
@xeji
Revert "libvirt: fix dlopen("libjansson.so.4")"
4ad233e 
This reverts commit 929a53f.

Upstream has reverted their move from yajl to jansson after 4.6.0
because of major issues. No point in trying to fix it.
Let's revert to libvirt 4.5.0 and wait for the next upstream release.
@xeji
Revert "libvirt: jansson required for qemu suppport"

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
528f4a2 
This reverts commit df05344.

Upstream has reverted their move from yajl to jansson after 4.6.0
because of major issues.
Let's revert to libvirt 4.5.0 and wait for the next upstream release.
@xeji
Revert "libvirt: 4.5.0 -> 4.6.0 (NixOS#44566)"
6b5b7d9 
This reverts commit 8835240.

4.6.0 is quite broken. Let's wait for the next release.
@xeji xeji requested a review from FRidh as a code owner August 21, 2018 20:19
@xeji
Copy link
Contributor Author

xeji commented Aug 21, 2018

@GrahamcOfBorg build libvirt

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libvirt

Partial log (click to expand)

Removing /nix/store/vv4mpc1kl4zl985r2g4n5y3jda3ca5cz-libvirt-4.5.0/share/gtk-doc
rmdir: failed to remove '/nix/store/vv4mpc1kl4zl985r2g4n5y3jda3ca5cz-libvirt-4.5.0/share': Directory not empty
gzipping man pages under /nix/store/vv4mpc1kl4zl985r2g4n5y3jda3ca5cz-libvirt-4.5.0/share/man/
/nix/store/5im29qx9rni3w8l3j8i2yr22sin55kxv-cctools-binutils-darwin/bin/strip is /nix/store/5im29qx9rni3w8l3j8i2yr22sin55kxv-cctools-binutils-darwin/bin/strip
stripping (with command /nix/store/5im29qx9rni3w8l3j8i2yr22sin55kxv-cctools-binutils-darwin/bin/strip and flags -S) in /nix/store/vv4mpc1kl4zl985r2g4n5y3jda3ca5cz-libvirt-4.5.0/lib  /nix/store/vv4mpc1kl4zl985r2g4n5y3jda3ca5cz-libvirt-4.5.0/libexec  /nix/store/vv4mpc1kl4zl985r2g4n5y3jda3ca5cz-libvirt-4.5.0/bin  /nix/store/vv4mpc1kl4zl985r2g4n5y3jda3ca5cz-libvirt-4.5.0/sbin
patching script interpreter paths in /nix/store/vv4mpc1kl4zl985r2g4n5y3jda3ca5cz-libvirt-4.5.0
/nix/store/vv4mpc1kl4zl985r2g4n5y3jda3ca5cz-libvirt-4.5.0/bin/virt-xml-validate: interpreter directive changed from "/bin/sh" to "/nix/store/zbhk0jhc9y8hmbcax9nvddbik3rgsary-bash-4.4-p23/bin/sh"
/nix/store/vv4mpc1kl4zl985r2g4n5y3jda3ca5cz-libvirt-4.5.0/libexec/libvirt-guests.sh: interpreter directive changed from "/bin/sh" to "/nix/store/zbhk0jhc9y8hmbcax9nvddbik3rgsary-bash-4.4-p23/bin/sh"
moving /nix/store/vv4mpc1kl4zl985r2g4n5y3jda3ca5cz-libvirt-4.5.0/sbin/* to /nix/store/vv4mpc1kl4zl985r2g4n5y3jda3ca5cz-libvirt-4.5.0/bin
/nix/store/vv4mpc1kl4zl985r2g4n5y3jda3ca5cz-libvirt-4.5.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libvirt

Partial log (click to expand)

patching script interpreter paths in /nix/store/rad9d4ip10a4q1wc0akp2nnbc6irpfy6-libvirt-4.5.0
/nix/store/rad9d4ip10a4q1wc0akp2nnbc6irpfy6-libvirt-4.5.0/libexec/libvirt-guests.sh: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
/nix/store/rad9d4ip10a4q1wc0akp2nnbc6irpfy6-libvirt-4.5.0/bin/virt-xml-validate: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
/nix/store/rad9d4ip10a4q1wc0akp2nnbc6irpfy6-libvirt-4.5.0/var/lib/rc.d/init.d/libvirtd: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
/nix/store/rad9d4ip10a4q1wc0akp2nnbc6irpfy6-libvirt-4.5.0/var/lib/rc.d/init.d/virtlockd: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
/nix/store/rad9d4ip10a4q1wc0akp2nnbc6irpfy6-libvirt-4.5.0/var/lib/rc.d/init.d/libvirt-guests: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
/nix/store/rad9d4ip10a4q1wc0akp2nnbc6irpfy6-libvirt-4.5.0/var/lib/rc.d/init.d/virtlogd: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/rad9d4ip10a4q1wc0akp2nnbc6irpfy6-libvirt-4.5.0...
moving /nix/store/rad9d4ip10a4q1wc0akp2nnbc6irpfy6-libvirt-4.5.0/sbin/* to /nix/store/rad9d4ip10a4q1wc0akp2nnbc6irpfy6-libvirt-4.5.0/bin
/nix/store/rad9d4ip10a4q1wc0akp2nnbc6irpfy6-libvirt-4.5.0

@xeji
libvirt: explicitly configure qemu support
ebac61b 
it is enabled by default in 4.5.0 but conditional in 4.6.0 so
let's already put it in here to avoid issues on the next bump.
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libvirt

Partial log (click to expand)

patching script interpreter paths in /nix/store/w76qmybq7w5iwx635702zf5wvpmvr1rg-libvirt-4.5.0
/nix/store/w76qmybq7w5iwx635702zf5wvpmvr1rg-libvirt-4.5.0/bin/virt-xml-validate: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
/nix/store/w76qmybq7w5iwx635702zf5wvpmvr1rg-libvirt-4.5.0/var/lib/rc.d/init.d/libvirt-guests: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
/nix/store/w76qmybq7w5iwx635702zf5wvpmvr1rg-libvirt-4.5.0/var/lib/rc.d/init.d/virtlockd: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
/nix/store/w76qmybq7w5iwx635702zf5wvpmvr1rg-libvirt-4.5.0/var/lib/rc.d/init.d/libvirtd: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
/nix/store/w76qmybq7w5iwx635702zf5wvpmvr1rg-libvirt-4.5.0/var/lib/rc.d/init.d/virtlogd: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
/nix/store/w76qmybq7w5iwx635702zf5wvpmvr1rg-libvirt-4.5.0/libexec/libvirt-guests.sh: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/w76qmybq7w5iwx635702zf5wvpmvr1rg-libvirt-4.5.0...
moving /nix/store/w76qmybq7w5iwx635702zf5wvpmvr1rg-libvirt-4.5.0/sbin/* to /nix/store/w76qmybq7w5iwx635702zf5wvpmvr1rg-libvirt-4.5.0/bin
/nix/store/w76qmybq7w5iwx635702zf5wvpmvr1rg-libvirt-4.5.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libvirt

Partial log (click to expand)

patching script interpreter paths in /nix/store/315hmjfgi8ziqq7yriv66da0zqm3bb8z-libvirt-4.5.0
/nix/store/315hmjfgi8ziqq7yriv66da0zqm3bb8z-libvirt-4.5.0/libexec/libvirt-guests.sh: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
/nix/store/315hmjfgi8ziqq7yriv66da0zqm3bb8z-libvirt-4.5.0/var/lib/rc.d/init.d/libvirt-guests: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
/nix/store/315hmjfgi8ziqq7yriv66da0zqm3bb8z-libvirt-4.5.0/var/lib/rc.d/init.d/virtlockd: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
/nix/store/315hmjfgi8ziqq7yriv66da0zqm3bb8z-libvirt-4.5.0/var/lib/rc.d/init.d/libvirtd: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
/nix/store/315hmjfgi8ziqq7yriv66da0zqm3bb8z-libvirt-4.5.0/var/lib/rc.d/init.d/virtlogd: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
/nix/store/315hmjfgi8ziqq7yriv66da0zqm3bb8z-libvirt-4.5.0/bin/virt-xml-validate: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/315hmjfgi8ziqq7yriv66da0zqm3bb8z-libvirt-4.5.0...
moving /nix/store/315hmjfgi8ziqq7yriv66da0zqm3bb8z-libvirt-4.5.0/sbin/* to /nix/store/315hmjfgi8ziqq7yriv66da0zqm3bb8z-libvirt-4.5.0/bin
/nix/store/315hmjfgi8ziqq7yriv66da0zqm3bb8z-libvirt-4.5.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libvirt

Partial log (click to expand)

Removing /nix/store/7ywy4czarvqald1h99ipcqm9wj9n7z3s-libvirt-4.5.0/share/gtk-doc
rmdir: failed to remove '/nix/store/7ywy4czarvqald1h99ipcqm9wj9n7z3s-libvirt-4.5.0/share': Directory not empty
gzipping man pages under /nix/store/7ywy4czarvqald1h99ipcqm9wj9n7z3s-libvirt-4.5.0/share/man/
/nix/store/5im29qx9rni3w8l3j8i2yr22sin55kxv-cctools-binutils-darwin/bin/strip is /nix/store/5im29qx9rni3w8l3j8i2yr22sin55kxv-cctools-binutils-darwin/bin/strip
stripping (with command /nix/store/5im29qx9rni3w8l3j8i2yr22sin55kxv-cctools-binutils-darwin/bin/strip and flags -S) in /nix/store/7ywy4czarvqald1h99ipcqm9wj9n7z3s-libvirt-4.5.0/lib  /nix/store/7ywy4czarvqald1h99ipcqm9wj9n7z3s-libvirt-4.5.0/libexec  /nix/store/7ywy4czarvqald1h99ipcqm9wj9n7z3s-libvirt-4.5.0/bin  /nix/store/7ywy4czarvqald1h99ipcqm9wj9n7z3s-libvirt-4.5.0/sbin
patching script interpreter paths in /nix/store/7ywy4czarvqald1h99ipcqm9wj9n7z3s-libvirt-4.5.0
/nix/store/7ywy4czarvqald1h99ipcqm9wj9n7z3s-libvirt-4.5.0/bin/virt-xml-validate: interpreter directive changed from "/bin/sh" to "/nix/store/zbhk0jhc9y8hmbcax9nvddbik3rgsary-bash-4.4-p23/bin/sh"
/nix/store/7ywy4czarvqald1h99ipcqm9wj9n7z3s-libvirt-4.5.0/libexec/libvirt-guests.sh: interpreter directive changed from "/bin/sh" to "/nix/store/zbhk0jhc9y8hmbcax9nvddbik3rgsary-bash-4.4-p23/bin/sh"
moving /nix/store/7ywy4czarvqald1h99ipcqm9wj9n7z3s-libvirt-4.5.0/sbin/* to /nix/store/7ywy4czarvqald1h99ipcqm9wj9n7z3s-libvirt-4.5.0/bin
/nix/store/7ywy4czarvqald1h99ipcqm9wj9n7z3s-libvirt-4.5.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libvirt

Partial log (click to expand)

patching script interpreter paths in /nix/store/3nhafh72ai3irhbm4h7hq8wwdp64ji0r-libvirt-4.5.0
/nix/store/3nhafh72ai3irhbm4h7hq8wwdp64ji0r-libvirt-4.5.0/bin/virt-xml-validate: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
/nix/store/3nhafh72ai3irhbm4h7hq8wwdp64ji0r-libvirt-4.5.0/var/lib/rc.d/init.d/libvirt-guests: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
/nix/store/3nhafh72ai3irhbm4h7hq8wwdp64ji0r-libvirt-4.5.0/var/lib/rc.d/init.d/virtlockd: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
/nix/store/3nhafh72ai3irhbm4h7hq8wwdp64ji0r-libvirt-4.5.0/var/lib/rc.d/init.d/libvirtd: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
/nix/store/3nhafh72ai3irhbm4h7hq8wwdp64ji0r-libvirt-4.5.0/var/lib/rc.d/init.d/virtlogd: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
/nix/store/3nhafh72ai3irhbm4h7hq8wwdp64ji0r-libvirt-4.5.0/libexec/libvirt-guests.sh: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/3nhafh72ai3irhbm4h7hq8wwdp64ji0r-libvirt-4.5.0...
moving /nix/store/3nhafh72ai3irhbm4h7hq8wwdp64ji0r-libvirt-4.5.0/sbin/* to /nix/store/3nhafh72ai3irhbm4h7hq8wwdp64ji0r-libvirt-4.5.0/bin
/nix/store/3nhafh72ai3irhbm4h7hq8wwdp64ji0r-libvirt-4.5.0

@xeji xeji merged commit ab6186b into NixOS:master Aug 21, 2018
@xeji xeji deleted the libvirt-revert branch August 21, 2018 22:00
@xeji
Copy link
Contributor Author

xeji commented Aug 31, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz

@LnL7 LnL7

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xeji @GrahamcOfBorg @fpletz @LnL7