Revert "Define wrapper env vars as full paths" #45442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbauer
requested review from
basvandijk,
Ericson2314,
peti and
ryantm
as code owners
matthewbauer
requested review from
vcunat,
Ericson2314 and
dezgeg
and removed request for
ryantm,
peti,
basvandijk and
Ericson2314
GrahamcOfBorg
added
6.topic: haskell
6.topic: emacs
6.topic: GNOME
GrahamcOfBorg
added
10.rebuild-linux: 501+
8.has: clean-up
8.has: package (new)
and removed
6.topic: emacs
6.topic: GNOME
Ericson2314
approved these changes
Aug 21, 2018
7c6f434c
approved these changes
Aug 21, 2018
9 tasks
|
How much breakage should this be shown to fix on master to be merged to master ahead of the other changes in |
|
Rebuild-wise, excluding anything else will probably not help. Stability-wise, I don't know (I haven't looked at most of the other changes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 89efc27, reversing
changes made to d0f1102. This is from PR #44767.
This PR had many unintended side effects. It seems prudent to just revert, hopefully making way to do this some time later on when all of the issues are resolved.