Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Define wrapper env vars as full paths" #45442

Merged
merged 3 commits into from
Aug 21, 2018
Merged

Revert "Define wrapper env vars as full paths" #45442

merged 3 commits into from
Aug 21, 2018
+76 −106

Conversation

matthewbauer
Copy link
Member

This reverts commit 89efc27, reversing
changes made to d0f1102. This is from PR #44767.

This PR had many unintended side effects. It seems prudent to just revert, hopefully making way to do this some time later on when all of the issues are resolved.

@matthewbauer
Revert "Merge pull request #44767 from obsidiansystems/wrapper-env-va…
162e396 
…r-path"

This reverts commit 89efc27, reversing
changes made to d0f1102.
@matthewbauer
Revert "openjdk: fixup build after #44767"

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
0fe85f1 
This reverts commit 38eea80.
@matthewbauer
Revert "treewide: fixup breakage due to absolute compiler path"
a8b8cb2 
This reverts commit d0888d1.
@matthewbauer matthewbauer changed the base branch from master to staging August 21, 2018 20:42
@matthewbauer matthewbauer changed the base branch from staging to master August 21, 2018 20:42
@matthewbauer matthewbauer changed the base branch from master to staging August 21, 2018 20:42
@matthewbauer matthewbauer requested review from vcunat, Ericson2314 and dezgeg and removed request for ryantm, peti, basvandijk and Ericson2314 August 21, 2018 20:42
@GrahamcOfBorg GrahamcOfBorg added 6.topic: haskell 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: vim 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux-stdenv This PR causes stdenv to rebuild 10.rebuild-darwin: 501+ labels Aug 21, 2018
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-linux: 501+ 8.has: clean-up 8.has: package (new) This PR adds a new package and removed 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: vim 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 21, 2018
@7c6f434c 7c6f434c mentioned this pull request Aug 21, 2018
Closed
9 tasks
@globin globin merged commit f7bc33a into staging Aug 21, 2018
@globin globin deleted the revert-wrapper-env-var-path branch August 21, 2018 23:14
@7c6f434c
Copy link
Member

How much breakage should this be shown to fix on master to be merged to master ahead of the other changes in staging? Or is staging merge including this imminent?

@edolstra edolstra mentioned this pull request Aug 22, 2018
Closed
@vcunat
Copy link
Member

vcunat commented Aug 22, 2018 •
edited
Loading

Rebuild-wise, excluding anything else will probably not help. Stability-wise, I don't know (I haven't looked at most of the other changes).

@vcunat vcunat mentioned this pull request Aug 23, 2018
Closed
@7c6f434c 7c6f434c mentioned this pull request Aug 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314

@7c6f434c 7c6f434c

@vcunat vcunat

@dezgeg dezgeg

Assignees
No one assigned
Labels
6.topic: haskell 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv This PR causes stdenv to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@matthewbauer @7c6f434c @vcunat @Ericson2314 @globin @GrahamcOfBorg