@vue/cli: init at 3.0.1 #45456
@vue/cli: init at 3.0.1 #45456
Conversation
| @@ -14,6 +14,7 @@ | |||
| , "sloc" | |||
| , "vue-cli" | |||
| , "swagger" | |||
| , "@vue/cli" | |||
There was a problem hiding this comment.
cc @svanderburg what is the preferred package set for node packages? We have apparently v6, v8, v10. I would prefer if most packages would be included only once in one of the node versions, due the size of these files.
There was a problem hiding this comment.
If v6 is end-of-life it should be also removed all together.
There was a problem hiding this comment.
Yeah I agree on that. Maybe move everything listed in node-packages-v6.json to node-packages-v10.json so we don't lose anything. My understanding is that node versions are close enough to not be a huge issue for most use cases.
There was a problem hiding this comment.
Here it says we should stick to the latest LTS: https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/node.section.md which is 8_x
There was a problem hiding this comment.
@Mic92 v6 is still supported by upstream https://github.com/nodejs/Release#release-schedule
There was a problem hiding this comment.
April 2019 means that we need to upgrade before the next release.
| @@ -14,6 +14,7 @@ | |||
| , "sloc" | |||
| , "vue-cli" | |||
There was a problem hiding this comment.
@vue/cli is Vue CLI v3
vue-cli is Vue CLI v2
Even though v2 is deprecated, most users still use it, we must give them enough time to switch...
There was a problem hiding this comment.
ok. Is it possible to add it to node-packages-v6? How can the resulting package be used?
There was a problem hiding this comment.
From the vue-cli v3 documentation: "Vue CLI requires Node.js version 8.9 or above"
|
This pull request will be part of #45700 |
Motivation for this change
Vue CLI v3 stable has been released.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)Some other Node packages have been upgraded when executing
generate.sh. I guess it is okay to include these changes in the PR (because well, It's hard to make sure what is needed by Vue CLI and what has just been upgraded because a new version exists), but I'm not 100% sure.