Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openmpi: fix hwloc NUMA cpu allocation capability #45459

Merged
merged 1 commit into from Aug 22, 2018
Merged

openmpi: fix hwloc NUMA cpu allocation capability #45459

merged 1 commit into from Aug 22, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

openmpi uses an internal version of hwloc. However, hwloc requires numctl for cpu binding.
This patch allows to use the --bind-to option with mpirun and to respect numa domains.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 22, 2018

@GrahamcOfBorg build openmpi

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: openmpi

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openmpi

Partial log (click to expand)

shrinking /nix/store/9r553a0zyfz8bmrim61nw2gzv5czsj4v-openmpi-3.1.0/lib/libopen-rte.so.40.10.0
shrinking /nix/store/9r553a0zyfz8bmrim61nw2gzv5czsj4v-openmpi-3.1.0/lib/libompitrace.so.40.10.0
shrinking /nix/store/9r553a0zyfz8bmrim61nw2gzv5czsj4v-openmpi-3.1.0/lib/libmpi_mpifh.so.40.10.0
shrinking /nix/store/9r553a0zyfz8bmrim61nw2gzv5czsj4v-openmpi-3.1.0/lib/openmpi/libompi_dbg_msgq.so
gzipping man pages under /nix/store/9r553a0zyfz8bmrim61nw2gzv5czsj4v-openmpi-3.1.0/share/man/
/nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip is /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip
stripping (with command /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip and flags -S) in /nix/store/9r553a0zyfz8bmrim61nw2gzv5czsj4v-openmpi-3.1.0/lib  /nix/store/9r553a0zyfz8bmrim61nw2gzv5czsj4v-openmpi-3.1.0/bin
patching script interpreter paths in /nix/store/9r553a0zyfz8bmrim61nw2gzv5czsj4v-openmpi-3.1.0
checking for references to /build in /nix/store/9r553a0zyfz8bmrim61nw2gzv5czsj4v-openmpi-3.1.0...
/nix/store/9r553a0zyfz8bmrim61nw2gzv5czsj4v-openmpi-3.1.0

@xeji xeji merged commit 1471e86 into NixOS:master Aug 22, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: openmpi

Partial log (click to expand)

  /nix/store/84y0w5a2y9da96yxnag8lrlhcmll012w-libmpc-1.1.0
  /nix/store/cni9w7gagyfzy7bn866f8203207p5j3n-gfortran-wrapper-7.3.0
  /nix/store/nrisvk8yqpzqgsbqwkmgj3lxkmmcnjs4-openmpi-3.1.0
  /nix/store/ygkghvq8ixd8y1f6wxwddl0rha343c50-gfortran-7.3.0
copying path '/nix/store/23p5nqp7a6kcckz9ax0b7v4hx8gs2rih-expand-response-params' from 'https://cache.nixos.org'...
copying path '/nix/store/84y0w5a2y9da96yxnag8lrlhcmll012w-libmpc-1.1.0' from 'https://cache.nixos.org'...
copying path '/nix/store/ygkghvq8ixd8y1f6wxwddl0rha343c50-gfortran-7.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/cni9w7gagyfzy7bn866f8203207p5j3n-gfortran-wrapper-7.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/nrisvk8yqpzqgsbqwkmgj3lxkmmcnjs4-openmpi-3.1.0' from 'https://cache.nixos.org'...
/nix/store/nrisvk8yqpzqgsbqwkmgj3lxkmmcnjs4-openmpi-3.1.0

@markuskowa markuskowa deleted the openmpi-fix branch August 23, 2018 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @xeji @GrahamcOfBorg