Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/cfssl: don't create user/group unless service is enabled #45441

Merged
merged 1 commit into from Aug 21, 2018

Conversation

lopsided98
Copy link
Contributor

@lopsided98 lopsided98 commented Aug 21, 2018

Motivation for this change

The user creation for cfssl is always enabled, causing a cfssl user and group to be created along with the home directory /var/lib/cfssl on every NixOS user's system.

Things done

This PR adds a mkIf cfg.enable guard around the entire configuration.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb srhb self-assigned this Aug 21, 2018
@srhb
Copy link
Contributor

srhb commented Aug 21, 2018

Thanks! Letting CI eval, then merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants