Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains.editors: 2018-09-18 #46866

Merged
merged 11 commits into from Sep 24, 2018
Merged

jetbrains.editors: 2018-09-18 #46866

merged 11 commits into from Sep 24, 2018

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Sep 18, 2018 •
edited

Motivation for this change

Editor upgrades.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@eadwu eadwu requested a review from edwtjo as a code owner September 18, 2018 20:59
@Mic92
Copy link
Member

Mic92 commented Sep 19, 2018

Can you start idea-ultimate?

$ idea-ultimate
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=lcd -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel
Start Failed: Internal error. Please report to http://jb.gg/ide/critical-startup-errors
java.lang.NoClassDefFoundError: com/intellij/openapi/application/PathManager
        at com.intellij.ide.Bootstrap.main(Bootstrap.java:17)
        at com.intellij.idea.Main.main(Main.java:61)
Caused by: java.lang.ClassNotFoundException: com.intellij.openapi.application.PathManager
        at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        ... 2 more

@Mic92
Copy link
Member

Mic92 commented Sep 19, 2018

pycharm-professional also does not start:

$ pycharm-professional
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=lcd -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel
Error: Could not find or load main class com.intellij.idea.Main

@eadwu
Copy link
Member Author

eadwu commented Sep 19, 2018 •
edited

idea-ultimate and pycharm-professional work for me result/bin/idea-ultimate and result/bin/pycharm-professional with the usual GTK warnings

(java:16308): Gtk-WARNING **: 08:55:13.496: Unable to locate theme engine in module_path: "adwaita",`
(java:16308): Gtk-WARNING **: 08:55:18.674: Default font does not have a positive size

The only notable change I did was to set _JAVA_AWT_WM_NONREPARENTING=1 in environment.variables for DWM.

@edwtjo edwtjo merged commit 4b1e337 into NixOS:master Sep 24, 2018
@eadwu eadwu deleted the jetbrains.editors/2018-09-18 branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eadwu @Mic92 @edwtjo @GrahamcOfBorg