Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/activation: Switch from bash to sh to avoid reading users bash config #46851

Merged
merged 1 commit into from Sep 18, 2018
Merged

nixos/activation: Switch from bash to sh to avoid reading users bash config #46851

merged 1 commit into from Sep 18, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Sep 18, 2018

Motivation for this change

This fixes #46750. This should also work with non-POSIX shells like in #46042.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @Ma27

@etu
nixos/activation: Switch from bash to sh to avoid reading users bash …
7aa0dbf 
…config

This fixes NixOS#46750. This should also work with non-POSIX shells like in NixOS#46042.
Ma27
Ma27 approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this 👍

@etu
Copy link
Contributor Author

etu commented Sep 18, 2018

@Ma27 Yeah, I didn't get any workaround with using bash to work. But sh is basically bash with less features... So I thought it's worth a shot to run plain sh instead... 😄

xeji
xeji approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xeji xeji merged commit 5664e64 into NixOS:master Sep 18, 2018
@etu etu deleted the nixos-activation-shell branch September 18, 2018 19:47
xeji pushed a commit that referenced this pull request Sep 18, 2018
@etu @xeji
nixos/activation: Switch from bash to sh to avoid reading users bash …
4c4aff3 
…config (#46851)

This fixes #46750. This should also work with non-POSIX shells like in #46042.

(cherry picked from commit 5664e64)
@etu etu mentioned this pull request Oct 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switch-to-configuration.pl:"reload user units" does not execute in user shell
4 participants
@etu @Ma27 @xeji @GrahamcOfBorg