Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aesop: fix build with vala_42 #46848

Merged
merged 1 commit into from Sep 18, 2018
Merged

aesop: fix build with vala_42 #46848

merged 1 commit into from Sep 18, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Fix this build failure against #45950

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @jtojnar

@xeji
Copy link
Contributor

xeji commented Sep 18, 2018

@GrahamcOfBorg build aesop

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: aesop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: aesop

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/2z2v30gpk7minz1wrp7q25ijksmb7893-aesop-1.0.5/bin/com.github.lainsce.aesop
shrinking RPATHs of ELF executables and libraries in /nix/store/2z2v30gpk7minz1wrp7q25ijksmb7893-aesop-1.0.5
shrinking /nix/store/2z2v30gpk7minz1wrp7q25ijksmb7893-aesop-1.0.5/bin/.com.github.lainsce.aesop-wrapped
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2z2v30gpk7minz1wrp7q25ijksmb7893-aesop-1.0.5/bin
patching script interpreter paths in /nix/store/2z2v30gpk7minz1wrp7q25ijksmb7893-aesop-1.0.5
checking for references to /build in /nix/store/2z2v30gpk7minz1wrp7q25ijksmb7893-aesop-1.0.5...
/nix/store/2z2v30gpk7minz1wrp7q25ijksmb7893-aesop-1.0.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: aesop

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/7a93alaymx0ry0b3mxh8v7f5vfh4mr5c-aesop-1.0.5/bin/com.github.lainsce.aesop
shrinking RPATHs of ELF executables and libraries in /nix/store/7a93alaymx0ry0b3mxh8v7f5vfh4mr5c-aesop-1.0.5
shrinking /nix/store/7a93alaymx0ry0b3mxh8v7f5vfh4mr5c-aesop-1.0.5/bin/.com.github.lainsce.aesop-wrapped
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7a93alaymx0ry0b3mxh8v7f5vfh4mr5c-aesop-1.0.5/bin
patching script interpreter paths in /nix/store/7a93alaymx0ry0b3mxh8v7f5vfh4mr5c-aesop-1.0.5
checking for references to /build in /nix/store/7a93alaymx0ry0b3mxh8v7f5vfh4mr5c-aesop-1.0.5...
/nix/store/7a93alaymx0ry0b3mxh8v7f5vfh4mr5c-aesop-1.0.5

@jtojnar jtojnar merged commit 747450e into NixOS:master Sep 18, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Sep 18, 2018

Thanks.

@xeji
Copy link
Contributor

xeji commented Sep 18, 2018

@worldofpeace as a frequent contributor I suggest you add yourself to ofborg's extra-known-users list so you can trigger ofborg builds yourself. Example PR: NixOS/ofborg#220

@worldofpeace
Copy link
Contributor Author

@xeji I was actually waiting for someone to suggest that as reinforcement 😄

@worldofpeace worldofpeace deleted the aesop/fix-build branch September 18, 2018 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @xeji @GrahamcOfBorg @jtojnar