-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
sqlite: 3.24.0 -> 3.25.3 #46852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqlite: 3.24.0 -> 3.25.3 #46852
Conversation
Success on x86_64-linux (full log) Attempted: sqlite Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: sqlite Partial log (click to expand)
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: sqlite Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: sqlite Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: sqlite Partial log (click to expand)
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: sqlite Partial log (click to expand)
|
SQLalchemy may need updating/fixing? Not sure. |
Success on x86_64-linux (full log) Attempted: sqlite Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: sqlite Partial log (click to expand)
|
Timed out, unknown build status on aarch64-linux (full log) Attempted: sqlite Partial log (click to expand)
|
pythonPackages.sqlalchemy fails a doctest for some reason, seems to happen with sqlite 3.25+ . Happens on current version of 1.2.11 as well as 1.2.12 and latest git. D'oh. |
@GrahamcOfBorg build pythonPackages.sqlalchemy python3Packages.sqlalchemy |
Timed out, unknown build status on x86_64-darwin (full log) Attempted: pythonPackages.sqlalchemy, python3Packages.sqlalchemy Partial log (click to expand)
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: pythonPackages.sqlalchemy, python3Packages.sqlalchemy Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: pythonPackages.sqlalchemy, python3Packages.sqlalchemy Partial log (click to expand)
|
189e3bd
to
ca56b9c
Compare
Rebased and bumped SQLAlchemy. Unfortunately, that didn't fix the failed test:
|
|
Success on aarch64-linux (full log) Attempted: sqlite Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: sqlite Partial log (click to expand)
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: sqlite Partial log (click to expand)
|
ca56b9c
to
521d4af
Compare
We should probably open an issue with sqlalchemy? I think the behaviour might be undefined in this case. The first element of the tuple could be either value. If I am wrong then we still have an sqlite issue… |
Agreed, especially since we've seen this for a few versions now.
If nothing else I bet they can tell us something useful without
much trouble :).
…On Wed, 14 Nov 2018 17:41:14 -0800, Andreas Rammhold ***@***.***> wrote:
We should probably open an issue with sqlalchemy? I think the behaviour might be undefined in this case. The first element of the tuple could be either value. If I am wrong then we still have an sqlite issue…
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#46852 (comment) part: text/html
|
848128a
to
cac48a6
Compare
We have a patch upstream that fixes this now: https://bitbucket.org/zzzeek/sqlalchemy/commits/63279a69e2b9277df5e97ace161fa3a1bb4f29cd/raw I updated the branch to carry the fixes and squashed the SQLAlchemy change into one commit. cc @dtzWill |
@GrahamcOfBorg build python3Packages.sqlalchemy pythonPackages.sqlalchemy |
cac48a6
to
92d854e
Compare
Success on aarch64-linux (full log) Attempted: sqlite Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: sqlite Partial log (click to expand)
|
92d854e
to
b8229dd
Compare
Rebased and fixed the commit message for sqlalchemy to actually conform to our guidelines (and ofborg should now also build it automagically). |
Success on x86_64-linux (full log) Attempted: python3Packages.sqlalchemy, pythonPackages.sqlalchemy Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: python3Packages.sqlalchemy, pythonPackages.sqlalchemy Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: sqlite Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: sqlite Partial log (click to expand)
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: python3Packages.sqlalchemy, pythonPackages.sqlalchemy Partial log (click to expand)
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: sqlite Partial log (click to expand)
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: sqlite Partial log (click to expand)
|
Wow, that's great! LGTM, rebuilding with this now! (but no reason to wait for that) |
@dtzWill It doesn't hurt if we wait for that. Just hit the button whenever you are happy ;-) |
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)