Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lollypop-portal: add python3 #46849

Merged
merged 1 commit into from Sep 18, 2018
Merged

lollypop-portal: add python3 #46849

merged 1 commit into from Sep 18, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

This build failure against #45950

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @jtojnar

@xeji
Copy link
Contributor

xeji commented Sep 18, 2018

@GrahamcOfBorg build lollypop-portal

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: lollypop-portal

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: lollypop-portal

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/nd9rf780i37zjvnn47i7lknnn0f4pndz-lollypop-portal-0.9.7/libexec/lollypop-portal
shrinking RPATHs of ELF executables and libraries in /nix/store/nd9rf780i37zjvnn47i7lknnn0f4pndz-lollypop-portal-0.9.7
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nd9rf780i37zjvnn47i7lknnn0f4pndz-lollypop-portal-0.9.7/libexec
patching script interpreter paths in /nix/store/nd9rf780i37zjvnn47i7lknnn0f4pndz-lollypop-portal-0.9.7
/nix/store/nd9rf780i37zjvnn47i7lknnn0f4pndz-lollypop-portal-0.9.7/libexec/.lollypop-portal-wrapped: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/nd9rf780i37zjvnn47i7lknnn0f4pndz-lollypop-portal-0.9.7...
/nix/store/nd9rf780i37zjvnn47i7lknnn0f4pndz-lollypop-portal-0.9.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: lollypop-portal

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/0gl26i8njx6nl50l2a4l2b7gc6ywd0k4-lollypop-portal-0.9.7/libexec/lollypop-portal
shrinking RPATHs of ELF executables and libraries in /nix/store/0gl26i8njx6nl50l2a4l2b7gc6ywd0k4-lollypop-portal-0.9.7
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0gl26i8njx6nl50l2a4l2b7gc6ywd0k4-lollypop-portal-0.9.7/libexec
patching script interpreter paths in /nix/store/0gl26i8njx6nl50l2a4l2b7gc6ywd0k4-lollypop-portal-0.9.7
/nix/store/0gl26i8njx6nl50l2a4l2b7gc6ywd0k4-lollypop-portal-0.9.7/libexec/.lollypop-portal-wrapped: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/sb88r9crdhinhkm6vpxwzf5zmij86p8v-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/0gl26i8njx6nl50l2a4l2b7gc6ywd0k4-lollypop-portal-0.9.7...
/nix/store/0gl26i8njx6nl50l2a4l2b7gc6ywd0k4-lollypop-portal-0.9.7

@jtojnar
Copy link
Contributor

jtojnar commented Sep 18, 2018

Would not buildPythonApplication fit here better?

@worldofpeace
Copy link
Contributor Author

Yeah, might as well for consistency across packages too.

@jtojnar
Copy link
Contributor

jtojnar commented Sep 18, 2018

@GrahamcOfBorg build lollypop-portal

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: lollypop-portal

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: lollypop-portal

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/b4rpz8qi4mlc4ggpzvxd8dg9ljqiszf0-lollypop-portal-0.9.7/libexec/lollypop-portal
shrinking RPATHs of ELF executables and libraries in /nix/store/b4rpz8qi4mlc4ggpzvxd8dg9ljqiszf0-lollypop-portal-0.9.7
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/b4rpz8qi4mlc4ggpzvxd8dg9ljqiszf0-lollypop-portal-0.9.7/libexec
patching script interpreter paths in /nix/store/b4rpz8qi4mlc4ggpzvxd8dg9ljqiszf0-lollypop-portal-0.9.7
/nix/store/b4rpz8qi4mlc4ggpzvxd8dg9ljqiszf0-lollypop-portal-0.9.7/libexec/.lollypop-portal-wrapped: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/b4rpz8qi4mlc4ggpzvxd8dg9ljqiszf0-lollypop-portal-0.9.7...
/nix/store/b4rpz8qi4mlc4ggpzvxd8dg9ljqiszf0-lollypop-portal-0.9.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: lollypop-portal

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/0yvbnkfx5x5j6dbvicsffs5m98179b15-lollypop-portal-0.9.7/libexec/lollypop-portal
shrinking RPATHs of ELF executables and libraries in /nix/store/0yvbnkfx5x5j6dbvicsffs5m98179b15-lollypop-portal-0.9.7
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0yvbnkfx5x5j6dbvicsffs5m98179b15-lollypop-portal-0.9.7/libexec
patching script interpreter paths in /nix/store/0yvbnkfx5x5j6dbvicsffs5m98179b15-lollypop-portal-0.9.7
/nix/store/0yvbnkfx5x5j6dbvicsffs5m98179b15-lollypop-portal-0.9.7/libexec/.lollypop-portal-wrapped: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/sb88r9crdhinhkm6vpxwzf5zmij86p8v-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/0yvbnkfx5x5j6dbvicsffs5m98179b15-lollypop-portal-0.9.7...
/nix/store/0yvbnkfx5x5j6dbvicsffs5m98179b15-lollypop-portal-0.9.7

@jtojnar
Copy link
Contributor

jtojnar commented Sep 18, 2018

Thank you.

@jtojnar jtojnar merged commit 4bc023b into NixOS:master Sep 18, 2018
@worldofpeace worldofpeace deleted the lollypop-portal/fix-build branch September 18, 2018 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @xeji @GrahamcOfBorg @jtojnar