Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arelle: fix build, use current python3 #46862

Merged
merged 1 commit into from Sep 19, 2018
Merged

arelle: fix build, use current python3 #46862

merged 1 commit into from Sep 19, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 18, 2018

Motivation for this change

ZHF #45960.

It was pinned to python34, build failed in dependency python34Packages.pytest. Use python3 instead.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
arelle: fix build, use current python3
fe770b8 
It was pinned to python34, build failed in dependency
python34Packages.pytest. Use python3(6) instead.
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: arelle

Partial log (click to expand)

these paths will be fetched (1.38 MiB download, 8.77 MiB unpacked):
  /nix/store/48kfa7i6av3gs37ira847agmz5898izw-python3.6-isodate-0.5.4
  /nix/store/9w422hdngmb005q8pvpgd5127myw8hii-python3.6-tkinter-3.6.6
  /nix/store/i2qrwgwm2p3ld4smrki0chkr6s67h9ds-python3.6-arelle-2017-08-24-2017-08-24
copying path '/nix/store/48kfa7i6av3gs37ira847agmz5898izw-python3.6-isodate-0.5.4' from 'https://cache.nixos.org'...
copying path '/nix/store/9w422hdngmb005q8pvpgd5127myw8hii-python3.6-tkinter-3.6.6' from 'https://cache.nixos.org'...
copying path '/nix/store/i2qrwgwm2p3ld4smrki0chkr6s67h9ds-python3.6-arelle-2017-08-24-2017-08-24' from 'https://cache.nixos.org'...
/nix/store/i2qrwgwm2p3ld4smrki0chkr6s67h9ds-python3.6-arelle-2017-08-24-2017-08-24

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: arelle

Partial log (click to expand)

  /nix/store/hfli524dcp5p783p58b5mq2dmf239nm5-python3.6-arelle-2017-08-24-2017-08-24
  /nix/store/inh1bka4927pafqq8a1p1f4n5w355dva-python3.6-tkinter-3.6.6
  /nix/store/iy5rhmlcbd725rpil7ib5shx4x216qzg-python3.6-lxml-4.2.4
  /nix/store/vrh6qwqzjw2d999w0acnyr6sfzq5kglf-python3.6-isodate-0.5.4
copying path '/nix/store/vrh6qwqzjw2d999w0acnyr6sfzq5kglf-python3.6-isodate-0.5.4' from 'https://cache.nixos.org'...
copying path '/nix/store/iy5rhmlcbd725rpil7ib5shx4x216qzg-python3.6-lxml-4.2.4' from 'https://cache.nixos.org'...
copying path '/nix/store/390mwg34c37ijpcwgv166r8g4j5lh3mj-tk-8.6.6' from 'https://cache.nixos.org'...
copying path '/nix/store/inh1bka4927pafqq8a1p1f4n5w355dva-python3.6-tkinter-3.6.6' from 'https://cache.nixos.org'...
copying path '/nix/store/hfli524dcp5p783p58b5mq2dmf239nm5-python3.6-arelle-2017-08-24-2017-08-24' from 'https://cache.nixos.org'...
/nix/store/hfli524dcp5p783p58b5mq2dmf239nm5-python3.6-arelle-2017-08-24-2017-08-24

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: arelle

Partial log (click to expand)


----------------------------------------------------------------------
Ran 1 test in 0.001s

FAILED (errors=1)
Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>
see log in c:\temp\testLog.txt
error: Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>
builder for '/nix/store/jg3im9im3l3fwg5svvqwcx3804i910y3-python3.6-arelle-2017-08-24-2017-08-24.drv' failed with exit code 1
error: build of '/nix/store/jg3im9im3l3fwg5svvqwcx3804i910y3-python3.6-arelle-2017-08-24-2017-08-24.drv' failed

@xeji
Copy link
Contributor Author

xeji commented Sep 18, 2018

Interesting. I cannot reproduce the failure on x86_64-linux.
Builds fine on my system but runs 0 tests. And yes, the derivation hash is the same.

@xeji
Copy link
Contributor Author

xeji commented Sep 19, 2018

@GrahamcOfBorg build arelle

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: arelle

Partial log (click to expand)

copying path '/nix/store/48kfa7i6av3gs37ira847agmz5898izw-python3.6-isodate-0.5.4' from 'https://cache.nixos.org'...
copying path '/nix/store/lbvngc5z814q0zjm6sygkxdbrin7g8sc-python3.6-lxml-4.2.4' from 'https://cache.nixos.org'...
copying path '/nix/store/hy8cjz62ncxgp15bbxk47lb4142drzyx-openblas-0.3.1' from 'https://cache.nixos.org'...
copying path '/nix/store/biihf7k6fwr5gy59f8n47jrmn7zmz4z1-libXrender-0.9.10' from 'https://cache.nixos.org'...
copying path '/nix/store/0mgpdp3hqrlixiqm0z2n7nwl10qsyw18-libXft-2.3.2' from 'https://cache.nixos.org'...
copying path '/nix/store/3yw80cam77vrpw3zy8zpq8snr3mkazvb-tk-8.6.6' from 'https://cache.nixos.org'...
copying path '/nix/store/9w422hdngmb005q8pvpgd5127myw8hii-python3.6-tkinter-3.6.6' from 'https://cache.nixos.org'...
copying path '/nix/store/zllibcziphjb5nplh230rdynp0m5l0mp-python3.6-numpy-1.15.1' from 'https://cache.nixos.org'...
copying path '/nix/store/i2qrwgwm2p3ld4smrki0chkr6s67h9ds-python3.6-arelle-2017-08-24-2017-08-24' from 'https://cache.nixos.org'...
/nix/store/i2qrwgwm2p3ld4smrki0chkr6s67h9ds-python3.6-arelle-2017-08-24-2017-08-24

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: arelle

Partial log (click to expand)

copying path '/nix/store/vrh6qwqzjw2d999w0acnyr6sfzq5kglf-python3.6-isodate-0.5.4' from 'https://cache.nixos.org'...
copying path '/nix/store/iy5rhmlcbd725rpil7ib5shx4x216qzg-python3.6-lxml-4.2.4' from 'https://cache.nixos.org'...
copying path '/nix/store/g9k0zqwxnnhcnh0xva80hsvsbv8ky54p-gfortran-7.3.0-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/54w9xzm9jrx9xk5bh11033hl4yikkldq-tcl-8.6.6' from 'https://cache.nixos.org'...
copying path '/nix/store/390mwg34c37ijpcwgv166r8g4j5lh3mj-tk-8.6.6' from 'https://cache.nixos.org'...
copying path '/nix/store/dr9s84h0yjlrzbsyyf0r06wsv6f30mf7-openblas-0.3.1' from 'https://cache.nixos.org'...
copying path '/nix/store/inh1bka4927pafqq8a1p1f4n5w355dva-python3.6-tkinter-3.6.6' from 'https://cache.nixos.org'...
copying path '/nix/store/4ff22jmi8pj57fd86009kmsbqnzjyq4x-python3.6-numpy-1.15.1' from 'https://cache.nixos.org'...
copying path '/nix/store/hfli524dcp5p783p58b5mq2dmf239nm5-python3.6-arelle-2017-08-24-2017-08-24' from 'https://cache.nixos.org'...
/nix/store/hfli524dcp5p783p58b5mq2dmf239nm5-python3.6-arelle-2017-08-24-2017-08-24

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: arelle

Partial log (click to expand)

warning: no files found matching 'README.txt'
writing manifest file 'Arelle.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.003s

OK
see log in c:\temp\testLog.txt
/nix/store/9mh8frn3q4pbqz8qzc27iws9rc3jyizg-python3.6-arelle-2017-08-24-2017-08-24

@xeji
Copy link
Contributor Author

xeji commented Sep 19, 2018

OK, now this looks exactly like on my local machine.

@xeji
Copy link
Contributor Author

xeji commented Sep 19, 2018

Let's call this a transient failure and see what happens on Hydra. If it happens again I'll disable tests.

@xeji xeji merged commit a0c5dd8 into NixOS:master Sep 19, 2018
@xeji xeji deleted the p/arelle branch September 19, 2018 20:18
xeji added a commit that referenced this pull request Sep 19, 2018
@xeji
arelle: fix build, use current python3 (#46862)
08c39f8 
It was pinned to python34, build failed in dependency
python34Packages.pytest. Use python3(6) instead.

(cherry picked from commit a0c5dd8)
@xeji
Copy link
Contributor Author

xeji commented Sep 19, 2018

backported: 08c39f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeji @GrahamcOfBorg