pythonPackages.nilearn: fix test_signal tests #46850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests failed on some machines, probably due to lower arithmetic presicion. Reduce required precision from 13 to 8 decimal digits.
|
@GrahamcOfBorg build python27Packages.nilearn python36Packages.nilearn |
|
Success on x86_64-darwin (full log) Attempted: python27Packages.nilearn, python36Packages.nilearn Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: python27Packages.nilearn, python36Packages.nilearn Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python27Packages.nilearn, python36Packages.nilearn Partial log (click to expand)
|
xeji
added a commit
that referenced
this pull request
Sep 19, 2018
These tests failed on some machines, probably due to lower arithmetic presicion. Reduce required precision from 13 to 8 decimal digits. (cherry picked from commit 970393c)
|
backported: fd0c124 |
xeji
added a commit
to xeji/nixpkgs
that referenced
this pull request
Sep 19, 2018
A previous attempt to fix tests failing on some machines (NixOS#46850) was unsuccessful, they still failed on Hydra sometimes while succeeding locally. Revert NixOS#46850 and disable these tests instead.
1 task
xeji
added a commit
that referenced
this pull request
Sep 19, 2018
xeji
added a commit
that referenced
this pull request
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
These tests failed on some hydra builders (Hydra example), probably due to lower arithmetic precision. The failure was not reproducible on my local machine.
Reduce required precision from 13 to 8 decimal digits, which should work everywhere.
ZHF #45960 - please backport.
Things done