dovecot: allow sasl_bind=yes in the LDAP driver. #46859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I'm not sure if I'm correctly adding to the |
Mic92
reviewed
Sep 19, 2018
| @@ -67,7 +69,8 @@ stdenv.mkDerivation rec { | |||
| ++ lib.optional (stdenv.isDarwin) "--enable-static" | |||
| ++ lib.optional withMySQL "--with-mysql" | |||
| ++ lib.optional withPgSQL "--with-pgsql" | |||
| ++ lib.optional withSQLite "--with-sqlite"; | |||
| ++ lib.optional withSQLite "--with-sqlite" | |||
| ++ lib.optional enableSASL "CFLAGS=-I${cyrus_sasl.dev}/include/sasl"; | |||
There was a problem hiding this comment.
Adding cyrus_sasl to buildInputs should have the same effect because of our c wrapper.
There was a problem hiding this comment.
$ nix-shell -p cyrus_sasl --command 'echo $NIX_CFLAGS_COMPILE | grep sasl'
-isystem /nix/store/80rpfirmjs2zbckhk9srv6432jbzrpms-cyrus-sasl-2.1.26-dev/include -isystem /nix/store/80rpfirmjs2zbckhk9srv6432jbzrpms-cyrus-sasl-2.1.26-dev/includeThere was a problem hiding this comment.
Or is there a different sasl in the include path?
Dovecot has its own SASL implementation, but needs Cyrus SASL's headers to bind to an LDAP server using SASL. This is useful to avoid the need to manage a dnpass= in dovecot-ldap.conf by using the Unix socket to authenticate. This is done with sasl_mech=EXTERNAL in dovecot-ldap.conf, and some olcAccess: with by dn="gidNumber=0+uidNumber=0,cn=peercred,cn=external,cn=auth" read in the slapd's cn=config for the LDAP database queried by dovecot/auth (which runs as root).
|
Thank you @Mic92, I didn't know that the C wrapper was already adding the right include flag. I've tested and updated a simplified commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dovecot has its own SASL implementation,
but needs Cyrus SASL's headers to bind to an LDAP server using SASL.
This is useful to avoid the need to manage a
dnpass=indovecot-ldap.confby using the Unix socket to authenticate.
This is done with
sasl_mech=EXTERNALindovecot-ldap.conf, and someolcAccess:withby dn="gidNumber=0+uidNumber=0,cn=peercred,cn=external,cn=auth" readin the slapd's
cn=configfor the LDAP DN queried bydovecot/auth(which runs asroot).Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)