misc pkgs: various cross fixes in preparation for darwin->linux for 18.09 #46858
Conversation
Ericson2314
changed the title
GrahamcOfBorg
added
6.topic: darwin
| @@ -324,7 +326,8 @@ in | |||
|
|
|||
| extraNativeBuildInputs = [ prevStage.patchelf prevStage.paxctl ] ++ | |||
| # Many tarballs come with obsolete config.sub/config.guess that don't recognize aarch64. | |||
| lib.optional (!localSystem.isx86) prevStage.updateAutotoolsGnuConfigScriptsHook; | |||
| lib.optional (!localSystem.isx86 || localSystem.libc == "musl") | |||
| prevStage.updateAutotoolsGnuConfigScriptsHook; | |||
There was a problem hiding this comment.
I can't remember if I asked before but I was wondering if we could just do this on x86 as well? Just for consistency.
There was a problem hiding this comment.
@matthewbauer I would always do it on all platforms, but that's a mass rebuild on hydra-cached platforms. I'm taking advantage of MUSL's tier-n+1 status to do this right on master :D.
|
IMO putting this in 18.09 is high risk little reward. Better to just shoot for 19.03 being the version that supports macOS -> Linux compilation. We have enough time to work out the kinks. |
|
What's the risk? Not too much is being changed, and none of it affects native builds. |
|
Oh you mean the overall thing? |
|
Yeah I guess if it's not a mass rebuild it's fine but otherwise it seems like there are always random issues with these kind of stdenv changes. |
|
Success on x86_64-linux (full log) Attempted: gcc Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gcc Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: gcc Partial log (click to expand)
|
…r assertions This is needed to access attributes of derivations on platforms where they cannot be built.
Want to make sure these are the same per host platform, without duplication.
Only the regular GCC is built with a libc dependency.
This isn't a MUSL thing, but just needed for cross compilation to x86. No one had tried this when all cross compilation was to linux + glibc, hence why no one noticed this until recently.
Ericson2314
force-pushed
the
darwin-to-linux-prep
branch
from
5ad18f5
to
2091133
Compare
|
Success on x86_64-linux (full log) Attempted: gcc Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: gcc Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gcc Partial log (click to expand)
|
Motivation for this change
Backport of #46857.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)