Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cython 0.28.5, hypothesis 3.69.2 #46875

Closed
wants to merge 2 commits into from
Closed

Cython 0.28.5, hypothesis 3.69.2 #46875

wants to merge 2 commits into from

Conversation

urkud
Copy link
Contributor

@urkud urkud commented Sep 18, 2018

Motivation for this change

Update 2 packages to their latest versions, fix cython build with python 3.7.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS: python 2.7, 3.6, 3.7
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@urkud
python.pkgs.hypothesis: 3.66.2 -> 3.69.2
6b6f4c2 
Also set checkPhase only if doCheck is true (may be, this trick should
be moved to the buildPythonPackage function).
@urkud
python.pkgs.cython: 0.28.3 -> 0.28.5
566ce68 
Also fix test failure with Python 3.7
@urkud urkud requested a review from FRidh as a code owner September 18, 2018 23:36
@FRidh FRidh self-assigned this Sep 19, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 19, 2018

Please change or re-open this pull request to the staging branch instead of master.

@FRidh
Copy link
Member

FRidh commented Sep 19, 2018

This is on hold until after release of 18.09. At that point we'll do more major updates such as matplotlib.

@FRidh
Copy link
Member

FRidh commented Sep 19, 2018 •
edited

Cython we may actually want to get in 18.09 though.

We should get Cython in.

@urkud
Copy link
Contributor Author

urkud commented Sep 19, 2018

@FRidh @Mic92 So, should I change the target branch? If yes, which one: staging, or staging-18.09, or something else?

@FRidh
Copy link
Member

FRidh commented Sep 20, 2018

No, leave it, I will cherry-pick this change as soon as we have a bit more space on Hydra again.

@FRidh FRidh changed the base branch from master to staging October 2, 2018 16:27
@alexeymuranov alexeymuranov mentioned this pull request Dec 11, 2018
Closed
@dotlambda
Copy link
Member

We should get Cython in.

It seems it didn't get in. Any reason to still backport?

@FRidh
Copy link
Member

FRidh commented Jan 6, 2019

More recent versions available on master.

@FRidh FRidh closed this Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@urkud @Mic92 @FRidh @dotlambda @GrahamcOfBorg