link-grammar: init at 5.5.0 #46863
Merged
link-grammar: init at 5.5.0 #46863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Sep 18, 2018
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "${pname}-${version}"; | ||
| version = "5.5.0"; |
siers
force-pushed
the
link-grammar
branch
2 times, most recently
from
3ae903b
to
7ee5e92
Compare
|
True! I've upped the version and the hash and it works. |
|
@GrahamcOfBorg build link-grammar |
|
Success on x86_64-darwin (full log) Attempted: link-grammar Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: link-grammar Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: link-grammar Partial log (click to expand)
|
|
Now I remember why I did not push this, I did not manage to make it work with system minisat. I wonder if we should bother though – reading some issues, they might replace it with a different solver soon. Do we need python bindings? If yes, they should probably be moved to a separate output: see https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/volume-key/default.nix, for example. |
pkgs/top-level/all-packages.nix
Outdated
| @@ -1421,6 +1421,8 @@ with pkgs; | |||
|
|
|||
| libxnd = callPackage ../development/libraries/libxnd { }; | |||
|
|
|||
| link-grammar = callPackages ../tools/text/link-grammar { }; | |||
There was a problem hiding this comment.
Should be singular, callPackage
|
@GrahamcOfBorg build link-grammar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Hasn't been packaged.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)@jtojnar gave me this nix file and said he'd be okay with maintaining it, but didn't want to submit a PR himself, so here it is.